Skip to content

Re-add tools:targetApi to firebase-common AndroidManifest. #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Re-add tools:targetApi to firebase-common AndroidManifest. #749

merged 1 commit into from
Aug 30, 2019

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 29, 2019

This attr had to be removed in #728 because a bug in the tooling that has been fixed now.

@rlazo
Re-add tools:targetApi to firebase-common AndroidManifest.
95c0521 
This attr had to be removed in
#728 because a
bug in the tooling that has been fixed now.
@rlazo rlazo requested a review from vkryachko August 29, 2019 18:29
@googlebot googlebot added the cla: yes Override cla label Aug 29, 2019
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.terminate() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.waitForPendingWrites() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 95c0521 link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo requested a review from VinayGuthal August 30, 2019 12:38
vkryachko
vkryachko reviewed Aug 30, 2019
View reviewed changes
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it now ok to add?

@rlazo
Copy link
Collaborator Author

rlazo commented Aug 30, 2019

Why is it now ok to add?

The bug in the tool is now fixed.

@rlazo rlazo merged commit 7533855 into master Aug 30, 2019
@rlazo rlazo deleted the rl.targetapi_restore branch August 30, 2019 18:20
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @vkryachko @googlebot