Skip to content

Re-add tools:targetApi to firebase-common AndroidManifest. #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Re-add tools:targetApi to firebase-common AndroidManifest. #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions firebase-common/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="5" by="lint 3.4.1" client="gradle" variant="all" version="3.4.1">
<!-- TODO: remove when bazel support tools:targetApi -->
<issue
id="UnusedAttribute"
message="Attribute `directBootAware` is only used in API level 24 and higher (current min is 14)"
errorLine1=" android:directBootAware=&quot;true&quot; android:exported=&quot;false&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="11"
column="9"/>
</issue>

</issues>
4 changes: 3 additions & 1 deletion firebase-common/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.google.firebase">
<!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
<!--<uses-sdk android:minSdkVersion="14"/>-->
<application>

<service android:name="com.google.firebase.components.ComponentDiscoveryService"
android:directBootAware="true" android:exported="false"/>
android:directBootAware="true" android:exported="false"
tools:targetApi="n" />

<provider
android:name="com.google.firebase.provider.FirebaseInitProvider"
Expand Down