FAD fixing file provider path bug (#2972)

* fixing file provider path bug

* Mimicing functionality that NAUTM uses

Co-authored-by: Manny Jimenez <[email protected]>

Author: manny-jimenez

firebase-app-distribution/src/main/AndroidManifest.xml

@@ -44,12 +44,12 @@
 
         <provider
             android:name="androidx.core.content.FileProvider"
-            android:authorities="${applicationId}.provider"
+            android:authorities="${applicationId}.appdistro.fileprovider"
             android:exported="false"
             android:grantUriPermissions="true">
             <meta-data
                 android:name="android.support.FILE_PROVIDER_PATHS"
-                android:resource="@xml/provider_paths" />
+                android:resource="@xml/appdistro_provider_paths" />
         </provider>
     </application>
 </manifest>

firebase-app-distribution/src/main/java/com/google/firebase/appdistribution/InstallActivity.java

@@ -45,14 +45,22 @@ protected void onCreate(@NonNull Bundle savedInstanceState) {
     String path = originalIntent.getStringExtra("INSTALL_PATH");
     Intent intent = new Intent(Intent.ACTION_VIEW);
     intent.putExtra(Intent.EXTRA_RETURN_RESULT, true);
-    Uri apkUri =
-        FileProvider.getUriForFile(
-            getApplicationContext(),
-            getApplicationContext().getPackageName() + ".provider",
-            new File(path));
+    File apkFile = new File(path);
     String APK_MIME_TYPE = "application/vnd.android.package-archive";
-    intent.setDataAndType(apkUri, APK_MIME_TYPE);
-    intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
+
+    if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.N) {
+      Uri apkUri =
+          FileProvider.getUriForFile(
+              getApplicationContext(),
+              getApplicationContext().getPackageName() + ".appdistro.fileprovider",
+              apkFile);
+      intent.setDataAndType(apkUri, APK_MIME_TYPE);
+      intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
+    } else {
+      LogWrapper.getInstance().d("Requesting a vanilla URI");
+      intent.setDataAndType(Uri.fromFile(apkFile), APK_MIME_TYPE);
+    }
+
     mStartForResult.launch(intent);
   }
 

firebase-app-distribution/src/main/java/com/google/firebase/appdistribution/UpdateApkClient.java

@@ -178,7 +178,13 @@ private void downloadToDisk(
     long bytesDownloaded = 0;
     try (BufferedOutputStream outputStream =
         new BufferedOutputStream(
-            firebaseApp.getApplicationContext().openFileOutput(fileName, Context.MODE_PRIVATE))) {
+            firebaseApp
+                .getApplicationContext()
+                .openFileOutput(
+                    fileName,
+                    android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.N
+                        ? Context.MODE_PRIVATE
+                        : Context.MODE_WORLD_READABLE))) {
 
       byte[] data = new byte[8 * 1024];
       int readSize = input.read(data);