Skip to content

FAD fixing file provider path bug #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2021
Merged

FAD fixing file provider path bug #2972

merged 2 commits into from
Sep 14, 2021

Conversation

manny-jimenez
Copy link
Contributor

No description provided.

@manny-jimenez manny-jimenez self-assigned this Sep 13, 2021
@googlebot googlebot added the cla: yes Override cla label Sep 13, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 70.09% (41715ed) to 69.52% (22e4402e) by -0.57%.

    Filename Base (41715ed) Head (22e4402e) Diff
    UpdateApkClient.java 68.15% 66.46% -1.69%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (22e4402e) is created by Prow via merging commits: 41715ed 4f2c3dd.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (41715ed) Head (22e4402e) Diff
    aar 110 kB 110 kB +452 B (+0.4%)
    apk (aggressive) 739 kB 739 kB +66 B (+0.0%)
    apk (release) 1.54 MB 1.54 MB +182 B (+0.0%)

Test Logs

Notes

Head commit (22e4402e) is created by Prow via merging commits: 41715ed 4f2c3dd.

@manny-jimenez manny-jimenez merged commit b9f0ab6 into master Sep 14, 2021
@manny-jimenez manny-jimenez deleted the FAD_provider_paths branch September 14, 2021 14:12
rachaprince
rachaprince reviewed Sep 15, 2021
View reviewed changes
firebase-app-distribution/src/main/AndroidManifest.xml
@@ -44,12 +44,12 @@

<provider
android:name="androidx.core.content.FileProvider"
android:authorities="${applicationId}.provider"
android:authorities="${applicationId}.appdistro.fileprovider"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, but I think we should change this to firebaseappdistribution.fileprovider because we don't use appdistro externally, and the firebase prefix helps customers quickly identify this authority as part of the Firebase ecosystem (and aligns with the name of the main folder for this SDK)

firebase-app-distribution/src/main/AndroidManifest.xml
android:exported="false"
android:grantUriPermissions="true">
<meta-data
android:name="android.support.FILE_PROVIDER_PATHS"
android:resource="@xml/provider_paths" />
android:resource="@xml/appdistro_provider_paths" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here, I think this should be firebase_app_distribution_provider_path

@firebase firebase locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachaprince rachaprince rachaprince left review comments

@pranavrajgopal pranavrajgopal pranavrajgopal approved these changes

Assignees

@manny-jimenez manny-jimenez

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manny-jimenez @google-oss-bot @pranavrajgopal @rachaprince @googlebot