Skip to content

Fix for checkCoverage not being defined. #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2020
Merged

Fix for checkCoverage not being defined. #1394

merged 3 commits into from
Mar 27, 2020

Conversation

yifanyang
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 27, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (fd3abfc)Head (7864054)Diff
firebase-inappmessagingapk (aggressive)601323.00601338.00+15.00 (+0.00%)
firebase-segmentationapk (aggressive)1017144.001017134.00-10.00 (-0.00%)
firebase-storageapk (aggressive)325624.00325639.00+15.00 (+0.00%)
firebase-commonapk (aggressive)82954.0082953.00-1.00 (-0.00%)
firebase-databaseapk (aggressive)325592.00325606.00+14.00 (+0.00%)
firebase-crashlyticsapk (aggressive)584010.00584011.00+1.00 (+0.00%)
firebase-dynamic-linksapk (aggressive)327448.00327463.00+15.00 (+0.00%)
firebase-installations-interopapk (aggressive)61713.0061720.00+7.00 (+0.01%)
firebase-configapk (aggressive)395832.00395821.00-11.00 (-0.00%)
firebase-datatransportapk (aggressive)116347.00116361.00+14.00 (+0.01%)
firebase-inappmessaging-displayapk (aggressive)1603057.001603047.00-10.00 (-0.00%)
firebase-functionsapk (aggressive)393470.00393474.00+4.00 (+0.00%)
firebase-database-collectionapk (aggressive)313620.00313619.00-1.00 (-0.00%)
baseapk (aggressive)10675.0010682.00+7.00 (+0.07%)
Metric Unit: byte

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2020 •
edited
Loading

Coverage Report

Affected SDKs

SDKTypeBase (fd3abfc)Head (7864054)Diff
firebase-inappmessaging?0.34? (?)
AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java?0.00? (?)
ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java?0.00? (?)
ProtoMarshallerClient_Factory.java?0.00? (?)
DisplayCallbacksImpl.java?0.93? (?)
Skipping 135 more entries... See the logs for full detail.
firebase-inappmessaging-display-ktx?1.00? (?)
InAppMessagingDisplay.kt?1.00? (?)
firebase-firestore-ktx?0.41? (?)
Firestore.kt?0.41? (?)
firebase-segmentation?0.54? (?)
CustomInstallationIdCache.java?0.94? (?)
CustomInstallationIdCacheEntryValue.java?1.00? (?)
FirebaseSegmentationRegistrar.java?1.00? (?)
Utils.java?0.71? (?)
Skipping 4 more entries... See the logs for full detail.
firebase-storage?0.85? (?)
FirebaseStorage.java?0.84? (?)
UploadTask.java?0.80? (?)
AdaptiveStreamBuffer.java?0.85? (?)
ListTask.java?0.85? (?)
Skipping 41 more entries... See the logs for full detail.
firebase-functions-ktx?1.00? (?)
Functions.kt?1.00? (?)
firebase-common?0.57? (?)
GlobalLibraryVersionRegistrar.java?0.50? (?)
FirebaseError.java?0.00? (?)
KotlinDetector.java?0.67? (?)
LibraryVersion.java?1.00? (?)
Skipping 17 more entries... See the logs for full detail.
firebase-inappmessaging-ktx?1.00? (?)
InAppMessaging.kt?1.00? (?)
firebase-database?0.52? (?)
ChildChangeAccumulator.java?0.84? (?)
NodeUtilities.java?0.74? (?)
Utilities.java?0.70? (?)
ListenHashProvider.java?0.00? (?)
Skipping 149 more entries... See the logs for full detail.
firebase-database-ktx?0.86? (?)
Database.kt?0.86? (?)
firebase-crashlytics?0.10? (?)
CommonUtils.java?0.00? (?)
AutoValue_CrashlyticsReport_Session_Event_Application_Execution_BinaryImage.java?0.48? (?)
InstallIdProvider.java?0.00? (?)
Settings.java?0.00? (?)
Skipping 118 more entries... See the logs for full detail.
firebase-dynamic-links-ktx?0.78? (?)
FirebaseDynamicLinks.kt?0.78? (?)
transport-backend-cct?0.78? (?)
AndroidClientInfoEncoder.java?1.00? (?)
AutoValue_LogEvent.java?0.60? (?)
AutoValue_ClientInfo.java?0.48? (?)
CctBackendFactory.java?1.00? (?)
Skipping 22 more entries... See the logs for full detail.
firebase-installations?0.60? (?)
FirebaseInstallationsException.java?0.75? (?)
FirebaseInstallationServiceClient.java?0.07? (?)
PersistedInstallation.java?0.97? (?)
AwaitListener.java?0.00? (?)
Skipping 15 more entries... See the logs for full detail.
firebase-dynamic-links?0.66? (?)
PendingDynamicLinkData.java?1.00? (?)
ShortDynamicLinkImplCreator.java?0.93? (?)
IDynamicLinksCallbacks.java?0.05? (?)
DynamicLinksApi.java?0.86? (?)
Skipping 11 more entries... See the logs for full detail.
transport-runtime?0.66? (?)
SQLiteEventStore_Factory.java?0.00? (?)
PersistedEvent.java?1.00? (?)
SchedulingConfigModule.java?0.00? (?)
WorkInitializer_Factory.java?0.00? (?)
Skipping 76 more entries... See the logs for full detail.
firebase-storage-ktx?1.00? (?)
Storage.kt?1.00? (?)
firebase-components?0.91? (?)
Dependency.java?0.97? (?)
EventHandler.java?0.00? (?)
ComponentRuntime.java?0.99? (?)
CycleDetector.java?0.98? (?)
Skipping 17 more entries... See the logs for full detail.
firebase-encoders-json?0.97? (?)
JsonValueObjectEncoderContext.java?0.99? (?)
JsonDataEncoderBuilder.java?0.93? (?)
Configurator.java?0.00? (?)
EncodingException.java?1.00? (?)
Skipping 8 more entries... See the logs for full detail.
firebase-common-ktx?0.90? (?)
Firebase.kt?0.90? (?)
firebase-abt?0.19? (?)
AbtException.java?0.50? (?)
AbtExperimentInfo.java?0.85? (?)
AbtComponent.java?0.00? (?)
AbtRegistrar.java?0.00? (?)
Skipping 2 more entries... See the logs for full detail.
firebase-config?0.89? (?)
ConfigStorageClient.java?1.00? (?)
ConfigGetParameterHandler.java?0.98? (?)
FirebaseRemoteConfigFetchThrottledException.java?1.00? (?)
ConfigMetadataClient.java?0.89? (?)
Skipping 20 more entries... See the logs for full detail.
firebase-datatransport?1.00? (?)
TransportRegistrar.java?1.00? (?)
firebase-inappmessaging-display?0.32? (?)
InflaterConfigModule_ProvidesLandscapeImageLayoutConfigFactory.java?0.00? (?)
PicassoModule.java?0.00? (?)
InAppMessageComponent.java?0.00? (?)
InflaterConfigModule_ProvidesBannerLandscapeLayoutConfigFactory.java?0.00? (?)
Skipping 69 more entries... See the logs for full detail.
firebase-functions?0.04? (?)
FirebaseFunctionsException.java?0.00? (?)
FirebaseContextProvider.java?0.00? (?)
HttpsCallOptions.java?0.00? (?)
FunctionsMultiResourceComponent.java?0.00? (?)
Skipping 7 more entries... See the logs for full detail.
firebase-database-collection?0.76? (?)
ImmutableSortedMap.java?0.32? (?)
RBTreeSortedMap.java?0.86? (?)
LLRBBlackValueNode.java?0.94? (?)
LLRBValueNode.java?0.86? (?)
Skipping 7 more entries... See the logs for full detail.
firebase-encoders-reflective?0.85? (?)
ObjectEncoderProvider.java?0.00? (?)
ReflectiveObjectEncoder.java?1.00? (?)
ReflectiveObjectEncoderProvider.java?0.80? (?)
firebase-firestore?0.43? (?)
DocumentRemoveOrBuilder.java?0.00? (?)
Stream.java?1.00? (?)
ArrayContainsFilter.java?1.00? (?)
WatchChangeAggregator.java?0.98? (?)
Skipping 254 more entries... See the logs for full detail.
firebase-config-ktx?0.75? (?)
RemoteConfig.kt?0.75? (?)
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.

@yifanyang yifanyang requested a review from vkryachko March 27, 2020 16:05
@yifanyang yifanyang merged commit 21f6adf into master Mar 27, 2020
@yifanyang yifanyang deleted the yifany/fix-check-coverage-changed branch March 27, 2020 17:55
@firebase firebase locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @vkryachko @googlebot