Skip to content

Fix for checkCoverage not being defined. #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Fix for checkCoverage not being defined. #1394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09a2521
Fix for `checkCoverage` not being defined.
yifanyang Mar 27, 2020
7c1081b
Test reformatting metrics report.
yifanyang Mar 27, 2020
7864054
Another test.
yifanyang Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .../src/main/groovy/com/google/firebase/gradle/plugins/ci/ContinuousIntegrationPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

package com.google.firebase.gradle.plugins.ci

import com.google.firebase.gradle.plugins.FirebaseLibraryPlugin
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.Task
Expand Down Expand Up @@ -102,6 +103,10 @@ class ContinuousIntegrationPlugin implements Plugin<Project> {
tasks.maybeCreate('check')
tasks.maybeCreate('deviceCheck')
}

if (!isFirebaseLibrary(it)) {
tasks.maybeCreate('checkCoverage')
}
}
}

Expand Down Expand Up @@ -167,4 +172,8 @@ class ContinuousIntegrationPlugin implements Plugin<Project> {
private static boolean isAndroidProject(Project project) {
ANDROID_PLUGINS.find { plugin -> project.plugins.hasPlugin(plugin) }
}

private static boolean isFirebaseLibrary(Project project) {
project.plugins.hasPlugin(FirebaseLibraryPlugin.class)
}
}