Only iterate across active targets in WatchChangeAggregator #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
Apr 3, 2020
| @@ -162,7 +163,13 @@ public void handleTargetChange(WatchTargetChange targetChange) { | |||
| if (!targetIds.isEmpty()) { | |||
| return targetIds; | |||
| } else { | |||
| return targetStates.keySet(); | |||
| List<Integer> activeIds = new ArrayList<>(); | |||
| for (int id : targetStates.keySet()) { | |||
There was a problem hiding this comment.
targetStates is a HashMap with Integer keys. By iterating on this with an int variable you're unboxing and then re-boxing to add to activeIds. This should be for (Integer id : ...).
This whole file is sloppy about this but let's not make the problem any worse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting from web.