Skip to content

Only iterate across active targets in WatchChangeAggregator #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Only iterate across active targets in WatchChangeAggregator #2847

merged 1 commit into from
Apr 1, 2020

Conversation

thebrianchen
Copy link

Follow up from the customer issue in which Firestore was iterating through inactive targets multiple times in the logs.

Additional change from prettier in database.ts that was probably not pushed up.

@thebrianchen thebrianchen requested a review from wilhuff March 31, 2020 21:24
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

SDKTypeBase (8e70e4a)Head (fff8170)Diff
@firebase/firestore/memorybrowser224475.00224488.00+13.00 (+0.01%)
module221655.00221668.00+13.00 (+0.01%)
esm2017170304.00170318.00+14.00 (+0.01%)
main397404.00397448.00+44.00 (+0.01%)
@firebase/firestorebrowser271055.00271068.00+13.00 (+0.00%)
module267834.00267847.00+13.00 (+0.00%)
esm2017216141.00216155.00+14.00 (+0.01%)
main488418.00488462.00+44.00 (+0.01%)
firebasefirebase.js846872.00846885.00+13.00 (+0.00%)
firebase-firestore.memory.js266750.00266763.00+13.00 (+0.00%)
firebase-firestore.js311995.00312008.00+13.00 (+0.00%)
Metric Unit: byte

Test Logs

wilhuff
wilhuff approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Apr 1, 2020
@thebrianchen thebrianchen merged commit ad406d2 into master Apr 1, 2020
@thebrianchen thebrianchen deleted the bc/active-targets branch April 1, 2020 16:06
This was referenced Apr 2, 2020
Merged
Merged
@firebase firebase locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @google-oss-bot @wilhuff