Skip to content

Fix flaky transaction tests #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fix flaky transaction tests #1444

merged 1 commit into from
Apr 9, 2020

Conversation

thebrianchen
Copy link

Porting from web.

@googlebot googlebot added the cla: yes Override cla label Apr 9, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage did not change between base commit (ed1b4ef) and head commit (380f4ad). However there are changes in individual files.

    Filename Base (ed1b4ef) Head (380f4ad) Diff
    AbstractStream.java 34.52% 32.14% -2.38%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 85.6 kB 85.6 kB -2 B (-0.0%)

  • firebase-common

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 82.9 kB 82.9 kB +3 B (+0.0%)

  • firebase-components

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 10.9 kB 11.0 kB +15 B (+0.1%)

  • firebase-config

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 396 kB 396 kB +6 B (+0.0%)

  • firebase-crashlytics-ndk

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 1.17 MB 1.17 MB +5 B (+0.0%)

  • firebase-database

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 326 kB 326 kB +4 B (+0.0%)

  • firebase-database-collection

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 314 kB 314 kB +7 B (+0.0%)

  • firebase-datatransport

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 116 kB 116 kB -1 B (-0.0%)

  • firebase-dynamic-links

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 327 kB 327 kB +1 B (+0.0%)

  • firebase-functions

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 393 kB 393 kB -10 B (-0.0%)

  • firebase-inappmessaging

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 853 kB 853 kB +7 B (+0.0%)

  • firebase-inappmessaging-display

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 1.81 MB 1.81 MB -1 B (-0.0%)

  • firebase-installations

    Type Base (ed1b4ef) Head (380f4ad) Diff
    aar 56.7 kB 56.8 kB +5 B (+0.0%)

  • firebase-installations-interop

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 61.7 kB 61.7 kB +7 B (+0.0%)

  • firebase-segmentation

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 802 kB 802 kB +6 B (+0.0%)

  • firebase-storage

    Type Base (ed1b4ef) Head (380f4ad) Diff
    apk (aggressive) 326 kB 326 kB +6 B (+0.0%)

Test Logs

@thebrianchen thebrianchen merged commit 98419c4 into master Apr 9, 2020
@firebase firebase locked and limited conversation to collaborators May 10, 2020
@kaibolay kaibolay deleted the bc/tx-flake branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @google-oss-bot @schmidt-sebastian @googlebot