Skip to content

Fix flaky transaction tests #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fix flaky transaction tests #2888

merged 1 commit into from
Apr 9, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Apr 8, 2020 •
edited
Loading

b/153595228

@thebrianchen thebrianchen requested a review from Feiyang1 April 8, 2020 23:51
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (ce3addb) and head commit (91962df).

Test Logs

@thebrianchen thebrianchen changed the title Bc/disable tx flake Disable flaky transaction tests Apr 9, 2020
@thebrianchen thebrianchen force-pushed the bc/disable-tx-flake branch from 7092f5d to 974d9bd Compare April 9, 2020 21:52
@thebrianchen thebrianchen changed the title Disable flaky transaction tests Fix flaky transaction tests Apr 9, 2020
schmidt-sebastian
schmidt-sebastian approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix on Android and iOS as well.

@thebrianchen thebrianchen merged commit bc39eb5 into master Apr 9, 2020
@thebrianchen thebrianchen deleted the bc/disable-tx-flake branch April 9, 2020 22:45
@schmidt-sebastian
Copy link
Contributor

Do you mind explaining in the bug you filed why your fix works?

This was referenced Apr 9, 2020
Merged
Merged
@firebase firebase locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @google-oss-bot @schmidt-sebastian @Feiyang1