Read stdout of the process before waiting for it to complete. #1951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that the process can block on writing to stdout if the amount of data written is bigger than default buffer size. Hence not trying to read from the process until it finishes causes it to block forever trying to write to its stdout.
rlazo
approved these changes
Sep 9, 2020
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (11bff86d) is created by Prow via merging commits: 8e8ee51 bdd3532. |
|
@vkryachko: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the process can block on writing to stdout if the
amount of data written is bigger than default buffer size.
Hence not trying to read from the process until it finishes causes it to
block forever trying to write to its stdout.