Skip to content

Read stdout of the process before waiting for it to complete. #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Read stdout of the process before waiting for it to complete. #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions buildSrc/src/main/java/com/google/firebase/gradle/plugins/ci/AffectedProjectFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,14 @@ Set<Project> find() {
private static Set<String> changedPaths(File workDir) {
try {
Process process =
Runtime.getRuntime().exec("git diff --name-only --submodule=diff HEAD@{0} HEAD@{1}", null, workDir);
process.waitFor();
return ImmutableSet.copyOf(
CharStreams.readLines(new InputStreamReader(process.getInputStream())));
Runtime.getRuntime()
.exec("git diff --name-only --submodule=diff HEAD@{0} HEAD@{1}", null, workDir);
try {
return ImmutableSet.copyOf(
CharStreams.readLines(new InputStreamReader(process.getInputStream())));
} finally {
process.waitFor();
}
} catch (IOException e) {
throw new GradleException("Could not determine changed files", e);
} catch (InterruptedException e) {
Expand Down