Skip to content

Fix the heartbeat integration test in Firestore #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

var-const
Copy link
Contributor

It was broken by #2012

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (5bc4d96) and head commit (8a674fbb).

Test Logs

Notes

Head commit (8a674fbb) is created by Prow via merging commits: 5bc4d96 e09fcaa.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (5bc4d96) and head commit (8a674fbb).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8a674fbb) is created by Prow via merging commits: 5bc4d96 e09fcaa.

@google-oss-bot
Copy link
Contributor

@var-const: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests e09fcaa link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@var-const var-const merged commit 26f1b13 into master Sep 30, 2020
@firebase firebase locked and limited conversation to collaborators Oct 31, 2020
@kaibolay kaibolay deleted the varconst/fix-tests branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants