Skip to content

Add Deferred<T> api definitions. #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Deferred<T> api definitions. #2120

wants to merge 1 commit into from

Conversation

vkryachko
Copy link
Member

This is needed to start preparing interop interfaces before we enable
deferred lint enforcement.

@vkryachko
Add Deferred<T> api definitions.
fd390f7 
This is needed to start preparing interop interfaces before we enable
deferred lint enforcement.
@google-cla google-cla bot added the cla: yes Override cla label Oct 29, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 29, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-components

    SDK overall coverage did not change between base commit (1dc2837) and head commit (0345c0d2). However there are changes in individual files.

    Filename Base (1dc2837) Head (0345c0d2) Diff
    Deferred.java ? 0.00% ?
    DeferredApi.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0345c0d2) is created by Prow via merging commits: 1dc2837 fd390f7.

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko requested a review from rlazo November 2, 2020 13:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 2, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-components

    Type Base (1dc2837) Head (0345c0d2) Diff
    aar 34.7 kB 35.7 kB +983 B (+2.8%)
    apk (release) 25.2 kB 25.4 kB +212 B (+0.8%)

Test Logs

Notes

Head commit (0345c0d2) is created by Prow via merging commits: 1dc2837 fd390f7.

@vkryachko
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed fd390f7 link /test check-changed
device-check-changed fd390f7 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rlazo
rlazo approved these changes Nov 5, 2020
View reviewed changes
firebase-components/src/main/java/com/google/firebase/components/annotations/DeferredApi.java
*
* <p>Calling {@link DeferredApi }-annotated methods is allowed only from:
*
* <ol>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ul may be a better fit since there's no order

firebase-components/src/main/java/com/google/firebase/inject/Deferred.java
* use(barProvider.get());
* });
* }
* }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra {

@vkryachko vkryachko closed this Nov 11, 2020
@vkryachko vkryachko deleted the vk.deferredApi branch November 11, 2020 14:24
@vkryachko
Copy link
Member Author

Superseded by #2167

@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @rlazo