Skip to content

Add firebase-annotations module. #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2020
Merged

Add firebase-annotations module. #2167

merged 2 commits into from
Nov 11, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Nov 11, 2020
@vkryachko vkryachko requested a review from rlazo November 11, 2020 14:15
@vkryachko vkryachko mentioned this pull request Nov 11, 2020
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 46.85% (4f3ffc5) to 46.80% (8c8784b3) by -0.05%.

    Filename Base (4f3ffc5) Head (8c8784b3) Diff
    GrpcCallProvider.java 68.18% 57.95% -10.23%

  • firebase-storage

    SDK overall coverage changed from 85.48% (4f3ffc5) to 85.89% (8c8784b3) by +0.40%.

    Filename Base (4f3ffc5) Head (8c8784b3) Diff
    StorageException.java 65.45% 69.09% +3.64%
    StorageTask.java 84.29% 84.89% +0.60%
    UploadTask.java 80.22% 82.05% +1.83%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8c8784b3) is created by Prow via merging commits: 4f3ffc5 e0945c2.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-annotations

    Type Base (4f3ffc5) Head (8c8784b3) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-installations

    Type Base (4f3ffc5) Head (8c8784b3) Diff
    aar 62.0 kB 62.0 kB -4 B (-0.0%)

Test Logs

Notes

Head commit (8c8784b3) is created by Prow via merging commits: 4f3ffc5 e0945c2.

rlazo
rlazo reviewed Nov 11, 2020
View reviewed changes
@vkryachko vkryachko merged commit 0d3be75 into master Nov 11, 2020
@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests e0945c2 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
@vkryachko vkryachko deleted the vk.firebase-annotations branch January 21, 2021 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @rlazo