Skip to content

Initial implementation of firebase-encoders-proto #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 27, 2020
Merged

Initial implementation of firebase-encoders-proto #2206

merged 5 commits into from
Nov 27, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Nov 26, 2020
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject encoders_firebase-encoders-proto:
error: Added package com.google.firebase.encoders.proto [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 26, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.30% (8cb30c1) to 50.32% (7ab8273b) by +0.01%.

    Filename Base (8cb30c1) Head (7ab8273b) Diff
    BooleanNode.java 100.00% 92.31% -7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DoubleNode.java 100.00% 88.24% -11.76%

  • firebase-encoders-proto

    SDK overall coverage changed from ? (8cb30c1) to 0.00% (7ab8273b) by ?.

    Filename Base (8cb30c1) Head (7ab8273b) Diff

  • firebase-firestore

    SDK overall coverage changed from 46.95% (8cb30c1) to 47.00% (7ab8273b) by +0.05%.

    Filename Base (8cb30c1) Head (7ab8273b) Diff
    GrpcCallProvider.java 57.95% 68.18% +10.23%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7ab8273b) is created by Prow via merging commits: 8cb30c1 17ce8be.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 26, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-encoders-proto

    Type Base (8cb30c1) Head (7ab8273b) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 21.1 kB ? (?)

Test Logs

Notes

Head commit (7ab8273b) is created by Prow via merging commits: 8cb30c1 17ce8be.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject encoders_firebase-encoders-proto:
error: Added package com.google.firebase.encoders.proto [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@vkryachko vkryachko requested a review from rlazo November 27, 2020 17:21
@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko merged commit b33927b into master Nov 27, 2020
@firebase firebase locked and limited conversation to collaborators Dec 28, 2020
@vkryachko vkryachko deleted the vk.protobuf_encoder branch January 21, 2021 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot