Skip to content

Fixing issues related with package visibility changes for Android 11. #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

eldhosembabu
Copy link
Contributor

Fixing issues related with package visibility changes for Android 11.

While targeting android 11, querying for activities or services which can handle intent returns 0 results. To support this querying in Android 11 and above we need to have the 'queries' tag mentioned in the manifest. Please see: https://developer.android.com/about/versions/11/privacy/package-visibility for details.

@google-cla google-cla bot added the cla: yes Override cla label Jan 12, 2021
Copy link
Contributor

@prakhar1989 prakhar1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (8fcd37c) and head commit (908fd22f).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (908fd22f) is created by Prow via merging commits: 8fcd37c 1ab342f.

@google-oss-bot
Copy link
Contributor

@eldhosembabu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
copyright-check 1ab342f link /test copyright-check
device-check-changed 1ab342f link /test device-check-changed
check-changed 1ab342f link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-inappmessaging-display

    Type Base (8fcd37c) Head (908fd22f) Diff
    aar 204 kB 204 kB +50 B (+0.0%)
    apk (aggressive) 1.43 MB 1.43 MB +112 B (+0.0%)
    apk (release) 4.54 MB 4.54 MB +116 B (+0.0%)

Test Logs

Notes

Head commit (908fd22f) is created by Prow via merging commits: 8fcd37c 1ab342f.

@eldhosembabu eldhosembabu merged commit b659461 into master Jan 13, 2021
@eldhosembabu eldhosembabu deleted the fiam-ab-not-working-b-177293308 branch January 13, 2021 18:38
rlazo added a commit that referenced this pull request Jan 13, 2021
vkryachko pushed a commit that referenced this pull request Jan 14, 2021
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@firebase firebase locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants