Skip to content

Revert "Fixing issues related with package visibility changes for Android 11." #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

Revert "Fixing issues related with package visibility changes for Android 11." #2323

merged 1 commit into from
Jan 14, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 13, 2021

Reverts #2316 This is breaking our tests.

@google-cla google-cla bot added the cla: yes Override cla label Jan 13, 2021
@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
copyright-check e63381f link /test copyright-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-inappmessaging-display

    SDK overall coverage changed from ? (04ac1f2) to 33.49% (8f14d89f) by ?.

    Click to show coverage changes in 73 files.
    Filename Base (04ac1f2) Head (8f14d89f) Diff
    AppComponent.java ? 0.00% ?
    ApplicationModule.java ? 0.00% ?
    ApplicationModule_ProvidesApplicationFactory.java ? 0.00% ?
    BackButtonHandler.java ? 33.33% ?
    BackButtonLayout.java ? 0.00% ?
    BannerBindingWrapper.java ? 92.31% ?
    BannerBindingWrapper_Factory.java ? 0.00% ?
    BaseModalLayout.java ? 10.67% ?
    BindingWrapper.java ? 80.00% ?
    BindingWrapperFactory.java ? 0.00% ?
    BindingWrapperFactory_Factory.java ? 0.00% ?
    CardBindingWrapper.java ? 6.06% ?
    CardBindingWrapper_Factory.java ? 0.00% ?
    CardLayoutLandscape.java ? 0.00% ?
    CardLayoutPortrait.java ? 0.00% ?
    DaggerAppComponent.java ? 0.00% ?
    DaggerInAppMessageComponent.java ? 0.00% ?
    DaggerUniversalComponent.java ? 0.00% ?
    FiamAnimator.java ? 11.63% ?
    FiamAnimator_Factory.java ? 0.00% ?
    FiamCardView.java ? 0.00% ?
    FiamFrameLayout.java ? 28.57% ?
    FiamImageLoader.java ? 86.67% ?
    FiamImageLoader_Factory.java ? 0.00% ?
    FiamListener.java ? 0.00% ?
    FiamRelativeLayout.java ? 28.57% ?
    FiamWindowManager.java ? 73.53% ?
    FiamWindowManager_Factory.java ? 0.00% ?
    FirebaseAppScope.java ? 0.00% ?
    FirebaseInAppMessagingDisplay.java ? 88.55% ?
    FirebaseInAppMessagingDisplayImpl.java ? 43.75% ?
    FirebaseInAppMessagingDisplayRegistrar.java ? 0.00% ?
    FirebaseInAppMessagingDisplay_Factory.java ? 0.00% ?
    HeadlessInAppMessagingModule.java ? 0.00% ?
    HeadlessInAppMessagingModule_ProvidesHeadlesssSingletonFactory.java ? 0.00% ?
    ImageBindingWrapper.java ? 86.96% ?
    ImageBindingWrapper_Factory.java ? 0.00% ?
    InAppMessageComponent.java ? 0.00% ?
    InAppMessageLayoutConfig.java ? 91.84% ?
    InAppMessageScope.java ? 0.00% ?
    InflaterConfigModule.java ? 50.00% ?
    InflaterConfigModule_ProvidesBannerLandscapeLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesBannerPortraitLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesDisplayMetricsFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesLandscapeImageLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesPortraitImageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule.java ? 0.00% ?
    InflaterModule_InAppMessageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule_ProvidesBannerMessageFactory.java ? 0.00% ?
    InflaterModule_ProvidesInflaterserviceFactory.java ? 0.00% ?
    LayoutConfigKey.java ? 0.00% ?
    Logging.java ? 60.00% ?
    MeasureUtils.java ? 0.00% ?
    ModalBindingWrapper.java ? 83.33% ?
    ModalBindingWrapper_Factory.java ? 0.00% ?
    ModalLayoutLandscape.java ? 0.00% ?
    ModalLayoutPortrait.java ? 4.29% ?
    OnSwipeUpListener.java ? 87.50% ?
    PicassoErrorListener.java ? 0.00% ?
    PicassoErrorListener_Factory.java ? 0.00% ?
    PicassoModule.java ? 0.00% ?
    PicassoModule_ProvidesFiamControllerFactory.java ? 0.00% ?
    RenewableTimer.java ? 0.00% ?
    RenewableTimer_Factory.java ? 0.00% ?
    ResizableImageView.java ? 81.25% ?
    SwipeDismissTouchListener.java ? 0.00% ?
    UniversalComponent.java ? 0.00% ?
    VerticalViewGroupMeasure.java ? 7.35% ?
    ViewMeasure.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8f14d89f) is created by Prow via merging commits: 04ac1f2 e63381f.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-inappmessaging-display

    Type Base (04ac1f2) Head (8f14d89f) Diff
    aar 204 kB 204 kB -50 B (-0.0%)
    apk (aggressive) 1.43 MB 1.43 MB -112 B (-0.0%)
    apk (release) 4.54 MB 4.54 MB -116 B (-0.0%)

Test Logs

Notes

Head commit (8f14d89f) is created by Prow via merging commits: 04ac1f2 e63381f.

@eldhosembabu
Copy link
Contributor

Would be great to know about the tests failing before reverting. We did this for fixing a p1. Thanks

@vkryachko
Copy link
Member

@eldhosembabu The PR broke CI, let's proceed with the rollback, please fix in a separate PR and make sure presubmits pass before merging.

@vkryachko vkryachko merged commit e32a965 into master Jan 14, 2021
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@rlazo @andreaowu
Revert "Fixing issues related with package visibility changes for And…
1ee2466 
…roid 11. (#2316)" (#2323)

This reverts commit b659461.
@firebase firebase locked and limited conversation to collaborators Feb 14, 2021
@rlazo rlazo deleted the revert-2316-fiam-ab-not-working-b-177293308 branch September 7, 2022 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @eldhosembabu @vkryachko