Skip to content

Firestore Bundles #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 3, 2021
Merged

Firestore Bundles #2398

merged 17 commits into from
Feb 3, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@schmidt-sebastian
Add ByteBufferInputStream
599c615 
This will allow all three overloads for loadBundle() to use the same decoding logic.

See #2322 for how this all comes together.
@schmidt-sebastian
Add BundleCache (#2301)
7bf4b6a
@schmidt-sebastian
Update ByteBufferInputStreamTest.java
02799ca
@schmidt-sebastian
Add JSON deserializer (#2331)
90d4c35
@schmidt-sebastian
Add bundle package (#2332)
01a8945
@schmidt-sebastian
Comment
b0618f2
@schmidt-sebastian
Merge branch 'mrschmidt/bundle/bytebufferoutputstream' of github.com:…
01c9c1a 
…firebase/firebase-android-sdk into mrschmidt/bundle/bytebufferoutputstream
@schmidt-sebastian
Merge branch 'mrschmidt/bundle/bytebufferoutputstream' into mrschmidt…
05d43d1 
…/bundle/master
@schmidt-sebastian
Merge
73f2d29
@schmidt-sebastian
Add Bundle Reader (#2333)
f184491
@schmidt-sebastian
Add LocalStore implementation for Bundles (#2342)
6b2f6d7
@schmidt-sebastian
Merge branch 'master' into mrschmidt/bundle/master
41a50ce
@schmidt-sebastian
Use JSON timestamps for Bundles (#2350)
3f47480
@schmidt-sebastian
Merge branch 'mrschmidt/bundle/master' of github.com:firebase/firebas…
21e21ff 
…e-android-sdk into mrschmidt/bundle/master
@schmidt-sebastian
Implement BundleLoader (#2346)
8efdba2
@schmidt-sebastian
Expose Firestore Bundles (#2369)
1e24541
@google-cla google-cla bot added the cla: yes Override cla label Feb 2, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.19% (4de8a91) to 48.62% (aa0650a6) by +1.42%.

    Click to show coverage changes in 28 files.
    Filename Base (4de8a91) Head (aa0650a6) Diff
    AsyncQueue.java 77.89% 76.88% -1.01%
    BundleCache.java ? 0.00% ?
    BundleCallback.java ? 0.00% ?
    BundleDocument.java ? 90.00% ?
    BundleElement.java ? 0.00% ?
    BundleLoader.java ? 100.00% ?
    BundleMetadata.java ? 76.92% ?
    BundleReader.java ? 94.87% ?
    BundleSerializer.java ? 88.98% ?
    BundledDocumentMetadata.java ? 77.27% ?
    BundledQuery.java ? 78.57% ?
    DocumentKey.java 96.88% 100.00% +3.13%
    FirebaseFirestore.java 48.55% 44.08% -4.47%
    FirestoreClient.java 35.71% 30.08% -5.63%
    LoadBundleTask.java 82.61% 83.16% +0.55%
    LoadBundleTaskProgress.java 74.29% 81.40% +7.11%
    LocalSerializer.java 97.32% 97.67% +0.35%
    LocalStore.java 98.70% 98.93% +0.23%
    MemoryBundleCache.java ? 100.00% ?
    NamedQuery.java ? 77.78% ?
    ObjectValue.java 99.01% 99.02% +0.01%
    RemoteSerializer.java 83.29% 83.96% +0.67%
    SQLiteBundleCache.java ? 90.00% ?
    SQLitePersistence.java 82.87% 83.06% +0.19%
    SQLiteSchema.java 92.86% 93.09% +0.23%
    SyncEngine.java 95.34% 93.49% -1.86%
    Target.java 26.58% 28.83% +2.25%
    Value.java 45.38% 45.65% +0.26%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (aa0650a6) is created by Prow via merging commits: 4de8a91 f251ffd.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (4de8a91) Head (aa0650a6) Diff
    aar 1.06 MB 1.10 MB +35.1 kB (+3.3%)
    apk (release) 3.18 MB 3.19 MB +11.0 kB (+0.3%)

Test Logs

Notes

Head commit (aa0650a6) is created by Prow via merging commits: 4de8a91 f251ffd.

wu-hui
wu-hui approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!!!

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 2, 2021
@schmidt-sebastian schmidt-sebastian merged commit 6ce7880 into master Feb 3, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/bundle/master branch February 3, 2021 00:01
@firebase firebase locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui