Make TransformResult non-nullable #2428
Conversation
Gil asked that this should not be part of #2383, but I think it still makes sense as an indepedent simplification
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (707e57bb) is created by Prow via merging commits: 1c62992 7bfed6c. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (707e57bb) is created by Prow via merging commits: 1c62992 7bfed6c. |
|
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -159,7 +159,7 @@ private void acknowledgeMutation(long documentVersion, @Nullable Object transfor | |||
| version, | |||
| transformResult != null | |||
| ? Collections.singletonList(TestUtil.wrap(transformResult)) | |||
| : null); | |||
| : Collections.emptyList()); | |||
There was a problem hiding this comment.
optional nit: you can just remove the Nullable annotation in the signature and change this method's overload to pass in an empty list instead of null.
There was a problem hiding this comment.
Hm, this would have been nice but unfortunately wrap throws when it is passed an empty Object.
Gil asked that this should not be part of #2383, but I think it still makes sense as an indepedent simplification