Skip to content

Make TransformResult non-nullable #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2021
Merged

Make TransformResult non-nullable #4538

merged 4 commits into from
Feb 26, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3f94696

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (5e7c013) Head (9ebd6a4) Diff
    browser 259 kB 259 kB -111 B (-0.0%)
    esm2017 202 kB 201 kB -107 B (-0.1%)
    main 530 kB 530 kB -187 B (-0.0%)
    module 259 kB 259 kB -111 B (-0.0%)
    react-native 202 kB 201 kB -107 B (-0.1%)

  • @firebase/firestore-exp

    Type Base (5e7c013) Head (9ebd6a4) Diff
    browser 199 kB 199 kB -107 B (-0.1%)
    main 505 kB 505 kB -187 B (-0.0%)
    module 199 kB 199 kB -107 B (-0.1%)
    react-native 200 kB 200 kB -107 B (-0.1%)

  • @firebase/firestore/bundle

    Type Base (5e7c013) Head (9ebd6a4) Diff
    browser 266 kB 266 kB -111 B (-0.0%)
    esm2017 155 kB 155 kB -107 B (-0.1%)
    main 526 kB 526 kB -187 B (-0.0%)
    module 266 kB 266 kB -111 B (-0.0%)
    react-native 155 kB 155 kB -107 B (-0.1%)

  • @firebase/firestore/memory

    Type Base (5e7c013) Head (9ebd6a4) Diff
    browser 196 kB 196 kB -111 B (-0.1%)
    esm2017 152 kB 152 kB -107 B (-0.1%)
    main 324 kB 324 kB -187 B (-0.1%)
    module 196 kB 196 kB -111 B (-0.1%)
    react-native 152 kB 152 kB -107 B (-0.1%)

  • @firebase/firestore/memory-bundle

    Type Base (5e7c013) Head (9ebd6a4) Diff
    browser 205 kB 204 kB -111 B (-0.1%)
    esm2017 155 kB 155 kB -107 B (-0.1%)
    main 321 kB 321 kB -187 B (-0.1%)
    module 205 kB 204 kB -111 B (-0.1%)
    react-native 155 kB 155 kB -107 B (-0.1%)

  • firebase

    Type Base (5e7c013) Head (9ebd6a4) Diff
    firebase-firestore.js 304 kB 303 kB -117 B (-0.0%)
    firebase-firestore.memory.js 243 kB 243 kB -117 B (-0.0%)
    firebase.js 845 kB 845 kB -117 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (5e7c013) and head commit (9ebd6a4).

thebrianchen
thebrianchen approved these changes Feb 26, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thebrianchen
thebrianchen reviewed Feb 26, 2021
View reviewed changes
packages/firestore/src/model/mutation.ts Outdated
@@ -701,7 +697,7 @@ function applyDeleteMutationToRemoteDocument(
mutationResult: MutationResult
): NoDocument {
debugAssert(
mutationResult.transformResults == null,
mutationResult.transformResults.length == 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint changes

@schmidt-sebastian schmidt-sebastian merged commit e558d3e into master Feb 26, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/transforms branch February 26, 2021 18:27
@firebase firebase locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen