Skip to content

Add getUtmParameters api method to PendingDynamicLinkData #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2021
Merged

Add getUtmParameters api method to PendingDynamicLinkData #2445

merged 2 commits into from
Feb 18, 2021

Conversation

eldhosembabu
Copy link
Contributor

Add getUtmParameters api method to PendingDynamicLinkData.

This is new api method to provide utm parameters associated with a firebase dynamic link.

Approved api review doc : https://docs.google.com/document/d/1NDBjiuCQEs3vnaPGfYKK2cdvJMIsJqukRtrZf8wsWCk

iOS PR for the same : firebase/firebase-ios-sdk#7505

@google-cla google-cla bot added the cla: yes Override cla label Feb 17, 2021
@googlebot googlebot added the cla: yes Override cla label Feb 17, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-dynamic-links

    SDK overall coverage changed from 71.31% (d4c30ec) to 72.28% (be982bff) by +0.97%.

    Filename Base (d4c30ec) Head (be982bff) Diff
    DynamicLinkUTMParams.java ? 95.45% ?
    PendingDynamicLinkData.java 100.00% 97.96% -2.04%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (be982bff) is created by Prow via merging commits: d4c30ec 2478e46.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dynamic-links:
error: Added method com.google.firebase.dynamiclinks.PendingDynamicLinkData.getUtmParameters() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-dynamic-links

    Type Base (d4c30ec) Head (be982bff) Diff
    aar 50.8 kB 52.2 kB +1.44 kB (+2.8%)
    apk (release) 936 kB 936 kB +244 B (+0.0%)

Test Logs

Notes

Head commit (be982bff) is created by Prow via merging commits: d4c30ec 2478e46.

@eldhosembabu eldhosembabu merged commit 3f237a3 into master Feb 18, 2021
@eldhosembabu eldhosembabu deleted the fdl-utm-params branch February 18, 2021 01:07
@firebase firebase locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prakhar1989 prakhar1989 prakhar1989 left review comments

@davidmotson davidmotson davidmotson approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

@JasonAHeron JasonAHeron Awaiting requested review from JasonAHeron

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldhosembabu @google-oss-bot @prakhar1989 @davidmotson @googlebot