Adding "utmParametersDictionary" api to FIRDynamicLink #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
|
paulb777
reviewed
Feb 10, 2021
FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLink.h
Outdated
Show resolved
Hide resolved
paulb777
reviewed
Feb 11, 2021
paulb777
approved these changes
Feb 11, 2021
ryanwilson
requested changes
Feb 11, 2021
FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLink.h
Outdated
Show resolved
Hide resolved
christibbs
reviewed
Feb 11, 2021
eldhosembabu
commented
Feb 11, 2021
ryanwilson
approved these changes
Feb 11, 2021
christibbs
approved these changes
Feb 11, 2021
eldhosembabu
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Feb 18, 2021
Add getUtmParameters api method to PendingDynamicLinkData. This is new api method to provide utm parameters associated with a firebase dynamic link. Approved api review doc : https://docs.google.com/document/d/1NDBjiuCQEs3vnaPGfYKK2cdvJMIsJqukRtrZf8wsWCk iOS PR for the same : firebase/firebase-ios-sdk#7505
9 tasks
ziadtamim
pushed a commit
to ziadtamim/firebase-ios-sdk
that referenced
this pull request
Mar 11, 2021
Adding "utmParametersDictionary" api to FIRDynamicLink. This new property will enable 3p developers to fetch the Utm parameters associated with a Firebase Dynamic Link. Related Issue: firebase#6730 API Review Doc : https://docs.google.com/document/d/1NDBjiuCQEs3vnaPGfYKK2cdvJMIsJqukRtrZf8wsWCk (Approved)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "utmParametersDictionary" api to FIRDynamicLink.
This new property will enable 3p developers to fetch the Utm parameters associated with a Firebase Dynamic Link.
Related Issue: #6730
API Review Doc : https://docs.google.com/document/d/1NDBjiuCQEs3vnaPGfYKK2cdvJMIsJqukRtrZf8wsWCk (Approved)