Skip to content

smoke tests for ml modeldownloader #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2021
Merged

smoke tests for ml modeldownloader #2453

merged 2 commits into from
Feb 25, 2021

Conversation

annzimmer
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.14% (ce1a078) to 50.19% (85315832) by +0.06%.

    Filename Base (ce1a078) Head (85315832) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DefaultPersistenceManager.java 74.76% 75.73% +0.97%
    ViewProcessor.java 92.10% 91.79% -0.30%
  • firebase-perf

    SDK overall coverage changed from 69.71% (ce1a078) to 69.75% (85315832) by +0.03%.

    Filename Base (ce1a078) Head (85315832) Diff
    TransportManager.java 94.58% 95.57% +0.99%
  • firebase-storage

    SDK overall coverage changed from 85.48% (ce1a078) to 85.66% (85315832) by +0.18%.

    Filename Base (ce1a078) Head (85315832) Diff
    StorageTask.java 84.29% 84.59% +0.30%
    UploadTask.java 79.85% 80.95% +1.10%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (85315832) is created by Prow via merging commits: ce1a078 4602670.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021

Binary Size Report

Affected SDKs

No changes between base commit (ce1a078) and head commit (85315832).

Test Logs

Notes

Head commit (85315832) is created by Prow via merging commits: ce1a078 4602670.

@annzimmer
Copy link
Contributor Author

/test device-check-changed

1 similar comment
@annzimmer
Copy link
Contributor Author

/test device-check-changed

@annzimmer annzimmer marked this pull request as ready for review February 22, 2021 16:40
@annzimmer annzimmer requested a review from rlazo February 22, 2021 16:41
@rlazo rlazo requested a review from davidmotson February 23, 2021 02:30
@annzimmer
Copy link
Contributor Author

/retest

1 similar comment
@annzimmer
Copy link
Contributor Author

/retest

@annzimmer
Copy link
Contributor Author

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@annzimmer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 4602670 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@annzimmer annzimmer merged commit 52b1dca into master Feb 25, 2021
@annzimmer annzimmer deleted the mlSmokeTest branch February 25, 2021 19:57
annzimmer added a commit that referenced this pull request Feb 26, 2021
annzimmer added a commit that referenced this pull request Feb 26, 2021
@firebase firebase locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants