Skip to content

Revert "smoke tests for ml modeldownloader" #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

annzimmer
Copy link
Contributor

Reverts #2453
Turns out this needs to wait until after official release of SDK.

@googlebot googlebot added the cla: yes Override cla label Feb 26, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.13% (9f6ade4) to 48.97% (7f7eff35) by -1.15%.

    Click to show coverage changes in 12 files.
    Filename Base (9f6ade4) Head (7f7eff35) Diff
    Connection.java 27.59% 13.79% -13.79%
    DoubleNode.java 88.24% 100.00% +11.76%
    LogWrapper.java 71.43% 57.14% -14.29%
    PersistentConnectionImpl.java 16.46% 13.41% -3.05%
    Repo.java 10.36% 8.88% -1.48%
    RetryHelper.java 70.97% 64.52% -6.45%
    SparseSnapshotTree.java 17.86% 7.14% -10.71%
    WebSocket.java 34.50% 27.00% -7.50%
    WebSocketException.java 50.00% 0.00% -50.00%
    WebSocketReceiver.java 12.82% 10.26% -2.56%
    WebSocketWriter.java 19.23% 16.67% -2.56%
    WebsocketConnection.java 32.39% 19.32% -13.07%
  • firebase-storage

    SDK overall coverage changed from 85.48% (9f6ade4) to 85.52% (7f7eff35) by +0.04%.

    Filename Base (9f6ade4) Head (7f7eff35) Diff
    UploadTask.java 79.85% 80.22% +0.37%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7f7eff35) is created by Prow via merging commits: 9f6ade4 5ea57f4.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (9f6ade4) and head commit (7f7eff35).

Test Logs

Notes

Head commit (7f7eff35) is created by Prow via merging commits: 9f6ade4 5ea57f4.

@visumickey
Copy link
Contributor

/test check-changed

@annzimmer
Copy link
Contributor Author

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@annzimmer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 5ea57f4 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@annzimmer annzimmer merged commit 76ec3e8 into master Feb 26, 2021
@annzimmer annzimmer deleted the revert-2453-mlSmokeTest branch February 26, 2021 21:34
@firebase firebase locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants