Codegen improvements #2528
Merged
Codegen improvements #2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an extra synthetic class that is otherwise generated to allow the Builder to create its parent class and vice versa.
This avoids a conflict with the test proto messages in protoc plugin's unit tests.
Coverage ReportAffected SDKsNo changes between base commit (e6472e8) and head commit (a825f895). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (a825f895) is created by Prow via merging commits: e6472e8 c1da93d. |
Binary Size ReportAffected SDKsNo changes between base commit (e6472e8) and head commit (a825f895). Test Logs
NotesHead commit (a825f895) is created by Prow via merging commits: e6472e8 c1da93d. |
VinayGuthal
approved these changes
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make constructors non-private.
This removes an extra synthetic class that is otherwise generated to
allow the Builder to create its parent class and vice versa.
Move e2e tests to its own package
This avoids a conflict with the test proto messages in protoc plugin's unit tests.