Skip to content

AppCheck javadoc nits #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

AppCheck javadoc nits #2621

merged 2 commits into from
Apr 27, 2021

Conversation

kevinthecheung
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Apr 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2021

Coverage Report

Affected SDKs

No changes between base commit (ae512bc) and head commit (6ae42c7a).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (6ae42c7a) is created by Prow via merging commits: ae512bc 0da1347.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2021

Binary Size Report

Affected SDKs

No changes between base commit (ae512bc) and head commit (6ae42c7a).

Test Logs

Notes

Head commit (6ae42c7a) is created by Prow via merging commits: ae512bc 0da1347.

Copy link
Member

@rosalyntan rosalyntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The check-changed failure looks like it's just a formatting issue --running the :appcheck:firebase-appcheck:verifyGoogleJavaFormat gradle task should fix it.

@rosalyntan rosalyntan merged commit 42c1e71 into firebase:master Apr 27, 2021
@firebase firebase locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants