Skip to content

AppCheck javadoc nits #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

AppCheck javadoc nits #2621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8c936
AppCheck javadoc nits
kevinthecheung Apr 25, 2021
0da1347
Fix formatting error
kevinthecheung Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appcheck/firebase-appcheck/src/main/java/com/google/firebase/appcheck/AppCheckProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
/**
* Interface for a provider that generates {@link AppCheckToken}s. This provider can be called at
* any time by any Firebase library that depends (optionally or otherwise) on {@link
* AppCheckToken}s. This provider should be responsible for determining if a new token can be
* created at the time of the call and returning that new token if it can be.
* AppCheckToken}s. This provider is responsible for determining if it can create a new token at the
* time of the call and returning that new token if it can.
*/
public interface AppCheckProvider {

Expand Down
8 changes: 4 additions & 4 deletions appcheck/firebase-appcheck/src/main/java/com/google/firebase/appcheck/FirebaseAppCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public static FirebaseAppCheck getInstance(@NonNull FirebaseApp firebaseApp) {
}

/**
* Installs the given {@link AppCheckProviderFactory}, overwriting any that previously was
* Installs the given {@link AppCheckProviderFactory}, overwriting any that were previously
* associated with this FirebaseAppCheck instance. Any {@link AppCheckTokenListener}s attached to
* this FirebaseAppCheck instance will be transferred from any existing factory to the newly
* this FirebaseAppCheck instance will be transferred from existing factories to the newly
* installed one.
*
* <p>Automatic token refreshing will only occur if the global {@code
Expand All @@ -52,9 +52,9 @@ public static FirebaseAppCheck getInstance(@NonNull FirebaseApp firebaseApp) {
public abstract void installAppCheckProviderFactory(@NonNull AppCheckProviderFactory factory);

/**
* Installs the given {@link AppCheckProviderFactory}, overwriting any that previously was
* Installs the given {@link AppCheckProviderFactory}, overwriting any that were previously
* associated with this FirebaseAppCheck instance. Any {@link AppCheckTokenListener}s attached to
* this FirebaseAppCheck instance will be transferred from any existing factory to the newly
* this FirebaseAppCheck instance will be transferred from existing factories to the newly
* installed one.
*
* <p>Automatic token refreshing will only occur if the {@code isTokenAutoRefreshEnabled} field is
Expand Down