Skip to content

Add comment to @PublicApi making it clear its only a convention for non-proguarded projects. #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
/**
* Indicates that this object (class, method, etc) should be retained while preguarding an SDK, but
* is safe to be proguarded away in the final app.
*
* <p>NOTE: For projects /not/ using proguard, the PublicApi annotation acts merely as a convention
* and has no actual impact. These projects must abide by normal java visibility rules to govern the
* visibility of methods in their public API.
*/
@KeepForSdk
@Target({ElementType.TYPE, ElementType.FIELD, ElementType.METHOD, ElementType.CONSTRUCTOR})
Expand Down