Skip to content

Updated README to include firebase-crashlytics-ndk build requirements. #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2021
Merged

Updated README to include firebase-crashlytics-ndk build requirements. #2667

merged 1 commit into from
May 14, 2021

Conversation

mrichards
Copy link
Contributor

No description provided.

@mrichards mrichards requested a review from vkryachko May 14, 2021 16:55
@googlebot googlebot added the cla: yes Override cla label May 14, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.01% (35adc36) to 49.99% (9f3d9de5) by -0.02%.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    DoubleNode.java 100.00% 88.24% -11.76%

  • firebase-firestore

    SDK overall coverage changed from 47.23% (35adc36) to 47.14% (9f3d9de5) by -0.09%.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    AsyncQueue.java 78.39% 77.89% -0.50%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%

  • firebase-inappmessaging

    SDK overall coverage changed from ? (35adc36) to 37.83% (9f3d9de5) by ?.

    Click to show coverage changes in 143 files.
    Filename Base (35adc36) Head (9f3d9de5) Diff
    AbtIntegrationHelper.java ? 60.87% ?
    AbtIntegrationHelper_Factory.java ? 0.00% ?
    Action.java ? 76.47% ?
    Analytics.java ? 0.00% ?
    AnalyticsConstants.java ? 0.00% ?
    AnalyticsEventsManager.java ? 85.19% ?
    AnalyticsEventsModule.java ? 0.00% ?
    AnalyticsEventsModule_ProvidesAnalyticsConnectorEventsFactory.java ? 0.00% ?
    AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java ? 0.00% ?
    AnalyticsListener.java ? 0.00% ?
    ApiClient.java ? 100.00% ?
    ApiClientModule.java ? 0.00% ?
    ApiClientModule_ProvidesApiClientFactory.java ? 0.00% ?
    ApiClientModule_ProvidesDataCollectionHelperFactory.java ? 0.00% ?
    ApiClientModule_ProvidesFirebaseAppFactory.java ? 0.00% ?
    ApiClientModule_ProvidesFirebaseInstallationsFactory.java ? 0.00% ?
    ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java ? 0.00% ?
    ApiClientModule_ProvidesTestDeviceHelperFactory.java ? 0.00% ?
    AppComponent.java ? 0.00% ?
    AppForeground.java ? 0.00% ?
    AppMeasurementModule.java ? 0.00% ?
    AppMeasurementModule_ProvidesAnalyticsConnectorFactory.java ? 0.00% ?
    AppMeasurementModule_ProvidesSubsriberFactory.java ? 0.00% ?
    ApplicationModule.java ? 0.00% ?
    ApplicationModule_DeveloperListenerManagerFactory.java ? 0.00% ?
    ApplicationModule_ProvidesApplicationFactory.java ? 0.00% ?
    AutoValue_InstallationIdResult.java ? 33.33% ?
    AutoValue_RateLimit.java ? 53.19% ?
    BannerMessage.java ? 75.00% ?
    Button.java ? 61.76% ?
    CampaignAnalytics.java ? 33.22% ?
    CampaignAnalyticsOrBuilder.java ? 0.00% ?
    CampaignCache.java ? 0.00% ?
    CampaignCacheClient.java ? 88.00% ?
    CampaignCacheClient_Factory.java ? 0.00% ?
    CampaignImpression.java ? 38.96% ?
    CampaignImpressionList.java ? 39.25% ?
    CampaignImpressionListOrBuilder.java ? 0.00% ?
    CampaignImpressionOrBuilder.java ? 0.00% ?
    CampaignMetadata.java ? 100.00% ?
    CampaignProto.java ? 27.48% ?
    CardMessage.java ? 78.48% ?
    ClientAppInfo.java ? 35.79% ?
    ClientAppInfoOrBuilder.java ? 0.00% ?
    Clock.java ? 0.00% ?
    CommonTypesProto.java ? 9.98% ?
    DaggerAppComponent.java ? 0.00% ?
    DaggerUniversalComponent.java ? 0.00% ?
    DataCollectionHelper.java ? 87.50% ?
    DataCollectionHelper_Factory.java ? 0.00% ?
    DeveloperListenerManager.java ? 90.20% ?
    DismissType.java ? 82.61% ?
    DisplayCallbacksFactory.java ? 100.00% ?
    DisplayCallbacksFactory_Factory.java ? 0.00% ?
    DisplayCallbacksImpl.java ? 93.40% ?
    EventType.java ? 76.19% ?
    ExperimentPayloadProto.java ? 5.12% ?
    FetchEligibleCampaignsRequest.java ? 32.97% ?
    FetchEligibleCampaignsRequestOrBuilder.java ? 0.00% ?
    FetchEligibleCampaignsResponse.java ? 42.86% ?
    FetchEligibleCampaignsResponseOrBuilder.java ? 0.00% ?
    FetchErrorReason.java ? 52.17% ?
    FiamAnalyticsConnectorListener.java ? 100.00% ?
    FiamFetchService.java ? 0.00% ?
    FirebaseAppScope.java ? 0.00% ?
    FirebaseInAppMessaging.java ? 66.67% ?
    FirebaseInAppMessagingCampaignAnalyticsProto.java ? 0.00% ?
    FirebaseInAppMessagingClickListener.java ? 0.00% ?
    FirebaseInAppMessagingContextualTrigger.java ? 0.00% ?
    FirebaseInAppMessagingDismissListener.java ? 0.00% ?
    FirebaseInAppMessagingDisplay.java ? 0.00% ?
    FirebaseInAppMessagingDisplayCallbacks.java ? 100.00% ?
    FirebaseInAppMessagingDisplayErrorListener.java ? 0.00% ?
    FirebaseInAppMessagingImpressionListener.java ? 0.00% ?
    FirebaseInAppMessagingRegistrar.java ? 0.00% ?
    FirebaseInAppMessaging_Factory.java ? 0.00% ?
    ForegroundFlowableModule.java ? 0.00% ?
    ForegroundFlowableModule_ProvidesAppForegroundEventStreamFactory.java ? 0.00% ?
    ForegroundNotifier.java ? 76.00% ?
    GrpcChannelModule.java ? 0.00% ?
    GrpcChannelModule_ProvidesGrpcChannelFactory.java ? 0.00% ?
    GrpcChannelModule_ProvidesServiceHostFactory.java ? 0.00% ?
    GrpcClient.java ? 100.00% ?
    GrpcClientModule.java ? 0.00% ?
    GrpcClientModule_ProvidesApiKeyHeadersFactory.java ? 0.00% ?
    GrpcClientModule_ProvidesInAppMessagingSdkServingStubFactory.java ? 0.00% ?
    GrpcClient_Factory.java ? 0.00% ?
    ImageData.java ? 71.43% ?
    ImageOnlyMessage.java ? 75.86% ?
    ImpressionStorageClient.java ? 100.00% ?
    ImpressionStorageClient_Factory.java ? 0.00% ?
    ImpressionStore.java ? 0.00% ?
    InAppMessage.java ? 24.24% ?
    InAppMessageStreamManager.java ? 91.35% ?
    InAppMessageStreamManager_Factory.java ? 0.00% ?
    InAppMessagingSdkServingGrpc.java ? 66.20% ?
    InstallationIdResult.java ? 100.00% ?
    Logging.java ? 81.82% ?
    MessageType.java ? 100.00% ?
    MessagesProto.java ? 36.13% ?
    MetricsLoggerClient.java ? 94.23% ?
    ModalMessage.java ? 74.07% ?
    ProgramaticContextualTriggers.java ? 0.00% ?
    ProgrammaticContextualTriggerFlowableModule.java ? 0.00% ?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggerStreamFactory.java ? 0.00% ?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggersFactory.java ? 0.00% ?
    ProgrammaticTrigger.java ? 0.00% ?
    ProtoMarshallerClient.java ? 91.40% ?
    ProtoMarshallerClient_Factory.java ? 0.00% ?
    ProtoStorageClient.java ? 100.00% ?
    ProtoStorageClientModule.java ? 0.00% ?
    ProtoStorageClientModule_ProvidesProtoStorageClientForCampaignFactory.java ? 0.00% ?
    ProtoStorageClientModule_ProvidesProtoStorageClientForImpressionStoreFactory.java ? 0.00% ?
    ProtoStorageClientModule_ProvidesProtoStorageClientForLimiterStoreFactory.java ? 0.00% ?
    ProviderInstaller.java ? 37.50% ?
    ProviderInstaller_Factory.java ? 0.00% ?
    ProxyAnalyticsConnector.java ? 67.95% ?
    RateLimit.java ? 0.00% ?
    RateLimitModule.java ? 0.00% ?
    RateLimitModule_ProvidesAppForegroundRateLimitFactory.java ? 0.00% ?
    RateLimitProto.java ? 52.69% ?
    RateLimiterClient.java ? 100.00% ?
    RateLimiterClient_Factory.java ? 0.00% ?
    RenderErrorReason.java ? 82.61% ?
    SchedulerModule.java ? 0.00% ?
    SchedulerModule_ProvidesComputeSchedulerFactory.java ? 0.00% ?
    SchedulerModule_ProvidesIOSchedulerFactory.java ? 0.00% ?
    SchedulerModule_ProvidesMainThreadSchedulerFactory.java ? 0.00% ?
    Schedulers.java ? 87.50% ?
    Schedulers_Factory.java ? 0.00% ?
    SharedPreferencesUtils.java ? 40.35% ?
    SharedPreferencesUtils_Factory.java ? 0.00% ?
    SystemClock.java ? 100.00% ?
    SystemClockModule.java ? 0.00% ?
    SystemClockModule_ProvidesSystemClockModuleFactory.java ? 0.00% ?
    SystemClock_Factory.java ? 0.00% ?
    TestDeviceHelper.java ? 100.00% ?
    TestDeviceHelper_Factory.java ? 0.00% ?
    Text.java ? 67.74% ?
    TransportClientModule.java ? 0.00% ?
    TransportClientModule_ProvidesMetricsLoggerClientFactory.java ? 0.00% ?
    TriggeredInAppMessage.java ? 100.00% ?
    UniversalComponent.java ? 0.00% ?

  • firebase-inappmessaging-display

    SDK overall coverage changed from ? (35adc36) to 33.49% (9f3d9de5) by ?.

    Click to show coverage changes in 73 files.
    Filename Base (35adc36) Head (9f3d9de5) Diff
    AppComponent.java ? 0.00% ?
    ApplicationModule.java ? 0.00% ?
    ApplicationModule_ProvidesApplicationFactory.java ? 0.00% ?
    BackButtonHandler.java ? 33.33% ?
    BackButtonLayout.java ? 0.00% ?
    BannerBindingWrapper.java ? 92.31% ?
    BannerBindingWrapper_Factory.java ? 0.00% ?
    BaseModalLayout.java ? 10.67% ?
    BindingWrapper.java ? 80.00% ?
    BindingWrapperFactory.java ? 0.00% ?
    BindingWrapperFactory_Factory.java ? 0.00% ?
    CardBindingWrapper.java ? 6.06% ?
    CardBindingWrapper_Factory.java ? 0.00% ?
    CardLayoutLandscape.java ? 0.00% ?
    CardLayoutPortrait.java ? 0.00% ?
    DaggerAppComponent.java ? 0.00% ?
    DaggerInAppMessageComponent.java ? 0.00% ?
    DaggerUniversalComponent.java ? 0.00% ?
    FiamAnimator.java ? 11.63% ?
    FiamAnimator_Factory.java ? 0.00% ?
    FiamCardView.java ? 0.00% ?
    FiamFrameLayout.java ? 28.57% ?
    FiamImageLoader.java ? 86.67% ?
    FiamImageLoader_Factory.java ? 0.00% ?
    FiamListener.java ? 0.00% ?
    FiamRelativeLayout.java ? 28.57% ?
    FiamWindowManager.java ? 71.83% ?
    FiamWindowManager_Factory.java ? 0.00% ?
    FirebaseAppScope.java ? 0.00% ?
    FirebaseInAppMessagingDisplay.java ? 88.55% ?
    FirebaseInAppMessagingDisplayImpl.java ? 43.75% ?
    FirebaseInAppMessagingDisplayRegistrar.java ? 0.00% ?
    FirebaseInAppMessagingDisplay_Factory.java ? 0.00% ?
    HeadlessInAppMessagingModule.java ? 0.00% ?
    HeadlessInAppMessagingModule_ProvidesHeadlesssSingletonFactory.java ? 0.00% ?
    ImageBindingWrapper.java ? 86.96% ?
    ImageBindingWrapper_Factory.java ? 0.00% ?
    InAppMessageComponent.java ? 0.00% ?
    InAppMessageLayoutConfig.java ? 91.84% ?
    InAppMessageScope.java ? 0.00% ?
    InflaterConfigModule.java ? 50.00% ?
    InflaterConfigModule_ProvidesBannerLandscapeLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesBannerPortraitLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesDisplayMetricsFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesLandscapeImageLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesPortraitImageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule.java ? 0.00% ?
    InflaterModule_InAppMessageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule_ProvidesBannerMessageFactory.java ? 0.00% ?
    InflaterModule_ProvidesInflaterserviceFactory.java ? 0.00% ?
    LayoutConfigKey.java ? 0.00% ?
    Logging.java ? 60.00% ?
    MeasureUtils.java ? 0.00% ?
    ModalBindingWrapper.java ? 83.33% ?
    ModalBindingWrapper_Factory.java ? 0.00% ?
    ModalLayoutLandscape.java ? 0.00% ?
    ModalLayoutPortrait.java ? 4.29% ?
    OnSwipeUpListener.java ? 87.50% ?
    PicassoErrorListener.java ? 0.00% ?
    PicassoErrorListener_Factory.java ? 0.00% ?
    PicassoModule.java ? 0.00% ?
    PicassoModule_ProvidesFiamControllerFactory.java ? 0.00% ?
    RenewableTimer.java ? 0.00% ?
    RenewableTimer_Factory.java ? 0.00% ?
    ResizableImageView.java ? 81.25% ?
    SwipeDismissTouchListener.java ? 0.00% ?
    UniversalComponent.java ? 0.00% ?
    VerticalViewGroupMeasure.java ? 7.35% ?
    ViewMeasure.java ? 0.00% ?

  • firebase-inappmessaging-display-ktx

    SDK overall coverage changed from ? (35adc36) to 100.00% (9f3d9de5) by ?.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    InAppMessagingDisplay.kt ? 100.00% ?

  • firebase-inappmessaging-ktx

    SDK overall coverage changed from ? (35adc36) to 100.00% (9f3d9de5) by ?.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    InAppMessaging.kt ? 100.00% ?

  • firebase-messaging

    SDK overall coverage changed from 83.43% (35adc36) to 83.56% (9f3d9de5) by +0.14%.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%

  • firebase-storage

    SDK overall coverage changed from 85.81% (35adc36) to 85.85% (9f3d9de5) by +0.04%.

    Filename Base (35adc36) Head (9f3d9de5) Diff
    StreamDownloadTask.java 88.41% 88.89% +0.48%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (9f3d9de5) is created by Prow via merging commits: 35adc36 b8db41a.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (35adc36) and head commit (9f3d9de5).

Test Logs

Notes

Head commit (9f3d9de5) is created by Prow via merging commits: 35adc36 b8db41a.

@mrichards mrichards merged commit 4bc47df into master May 14, 2021
@mrichards mrichards deleted the crashlytics-readme branch May 14, 2021 17:12
@google-oss-bot
Copy link
Contributor

@mrichards: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed b8db41a link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrichards @google-oss-bot @vkryachko @googlebot