Skip to content

Remove errorneous line. #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Remove errorneous line. #2730

merged 1 commit into from
Jun 14, 2021

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from rlazo June 14, 2021 16:59
@googlebot googlebot added the cla: yes Override cla label Jun 14, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (98e066a) and head commit (28d6a431).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (28d6a431) is created by Prow via merging commits: 98e066a d1880d3.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (98e066a) and head commit (28d6a431).

Test Logs

Notes

Head commit (28d6a431) is created by Prow via merging commits: 98e066a d1880d3.

@vkryachko
Copy link
Member Author

vkryachko commented Jun 14, 2021

/test check-changed

@vkryachko vkryachko merged commit 30ee760 into master Jun 14, 2021
@vkryachko vkryachko deleted the vk.ver_fix branch June 14, 2021 17:35
@google-oss-bot
Copy link
Contributor

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (d1880d3). Diffing against base commit (98e066a) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait122.0 ms160.0 ms131.5 ms144.1 ms157.1 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms64.0 ms52.0 ms60.2 ms63.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms90.0 ms74.5 ms85.0 ms89.1 ms
  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait118.0 ms150.0 ms137.5 ms145.3 ms149.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms72.0 ms53.5 ms55.2 ms69.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms87.0 ms69.5 ms78.1 ms85.5 ms
  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait132.0 ms177.0 ms148.5 ms166.2 ms177.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms59.0 ms48.5 ms54.4 ms58.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait58.0 ms98.0 ms69.5 ms86.1 ms95.9 ms
  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait138.0 ms186.0 ms159.5 ms165.0 ms182.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms64.0 ms51.5 ms56.1 ms62.7 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait49.0 ms100.0 ms82.5 ms89.7 ms99.2 ms
  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait127.0 ms172.0 ms149.5 ms154.2 ms169.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms65.0 ms48.0 ms62.2 ms64.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms89.0 ms74.5 ms84.3 ms88.6 ms
  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait135.0 ms164.0 ms146.0 ms159.3 ms163.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms62.0 ms49.0 ms60.0 ms61.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms106.0 ms72.5 ms85.3 ms102.6 ms
  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait122.0 ms163.0 ms141.0 ms150.2 ms160.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms68.0 ms56.0 ms62.2 ms67.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms86.0 ms74.0 ms79.6 ms85.8 ms
  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait134.0 ms171.0 ms149.5 ms158.4 ms169.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait32.0 ms72.0 ms50.5 ms64.1 ms70.7 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait47.0 ms98.0 ms68.0 ms84.2 ms95.7 ms
  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait161.0 ms213.0 ms184.0 ms197.9 ms211.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait42.0 ms69.0 ms53.5 ms61.2 ms67.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms99.0 ms76.5 ms88.2 ms97.3 ms
  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait139.0 ms192.0 ms154.5 ms175.6 ms189.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms71.0 ms56.0 ms67.1 ms70.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms88.0 ms71.5 ms86.2 ms88.0 ms
  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait147.0 ms181.0 ms159.5 ms175.0 ms179.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms64.0 ms51.5 ms60.3 ms63.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait61.0 ms94.0 ms80.0 ms91.0 ms93.4 ms
  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms185.0 ms142.5 ms151.4 ms179.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms63.0 ms52.5 ms57.0 ms61.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait57.0 ms91.0 ms69.5 ms80.3 ms89.5 ms

@firebase firebase locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants