Skip to content

Decouple smoke tests from SDK gradle version. #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2021
Merged

Decouple smoke tests from SDK gradle version. #2785

merged 2 commits into from
Jul 7, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jul 2, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.02% (5dfdf2a) to 50.00% (7e265b7c) by -0.02%.

    Filename Base (5dfdf2a) Head (7e265b7c) Diff
    BooleanNode.java 100.00% 92.31% -7.69%
    ViewProcessor.java 92.10% 91.79% -0.30%

  • firebase-storage

    SDK overall coverage did not change between base commit (5dfdf2a) and head commit (7e265b7c). However there are changes in individual files.

    Filename Base (5dfdf2a) Head (7e265b7c) Diff
    StorageTask.java 84.29% 84.59% +0.30%
    StreamDownloadTask.java 88.89% 88.41% -0.48%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7e265b7c) is created by Prow via merging commits: 5dfdf2a 3f835bb.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (5dfdf2a) and head commit (7e265b7c).

Test Logs

Notes

Head commit (7e265b7c) is created by Prow via merging commits: 5dfdf2a 3f835bb.

@yifanyang yifanyang force-pushed the yifany/smoke-gradle branch from dad1fc7 to dd34340 Compare July 2, 2021 18:49
@yifanyang yifanyang force-pushed the yifany/smoke-gradle branch from dd34340 to e0d95ec Compare July 2, 2021 19:17
@yifanyang
Copy link
Contributor Author

/test smoke-tests

@yifanyang
Set smoke-tests to be its own root project.;
3f835bb 
Make smoke-tests its own root project.
@yifanyang
Copy link
Contributor Author

/test smoke-tests

@yifanyang
Copy link
Contributor Author

/test check-changed

@yifanyang yifanyang requested review from vkryachko and rlazo July 7, 2021 17:24
@yifanyang
Copy link
Contributor Author

/test check-changed

@yifanyang
Copy link
Contributor Author

/retest

1 similar comment
@yifanyang
Copy link
Contributor Author

/retest

@yifanyang
Copy link
Contributor Author

/test check-changed

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 3f835bb link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang merged commit 20cd7fa into master Jul 7, 2021
@yifanyang yifanyang deleted the yifany/smoke-gradle branch July 7, 2021 23:49
yifanyang added a commit that referenced this pull request Jul 13, 2021
@yifanyang
Revert "Decouple smoke tests from SDK gradle version (#2785)"
9ea5cc0 
This reverts commit 20cd7fa.
@yifanyang yifanyang mentioned this pull request Jul 13, 2021
Merged
yifanyang added a commit that referenced this pull request Jul 13, 2021
@yifanyang
Rollback #2785, which made bom generation and crashlytics smoke test …
4f1cdc8 
…fail. (#2825)

Revert "Decouple smoke tests from SDK gradle version (#2785)"

This reverts commit 20cd7fa.
@firebase firebase locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @rlazo @googlebot