Skip to content

Rollback #2785, which made bom generation and crashlytics smoke test fail. #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2021
Merged

Rollback #2785, which made bom generation and crashlytics smoke test fail. #2825

merged 2 commits into from
Jul 13, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jul 13, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 13, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.18% (0d95ad5) to 47.10% (e6d4114c) by -0.09%.

    Filename Base (0d95ad5) Head (e6d4114c) Diff
    AsyncQueue.java 78.39% 77.89% -0.50%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%

  • firebase-messaging

    SDK overall coverage changed from ? (0d95ad5) to 83.43% (e6d4114c) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (0d95ad5) Head (e6d4114c) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e6d4114c) is created by Prow via merging commits: 0d95ad5 9ea5cc0.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 13, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (0d95ad5) and head commit (e6d4114c).

Test Logs

Notes

Head commit (e6d4114c) is created by Prow via merging commits: 0d95ad5 9ea5cc0.

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 9ea5cc0 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang changed the title Trigger smoke tests. Rollback #2785, as it made bom generation and smoke test for crashlytics fail. Jul 13, 2021
@yifanyang yifanyang changed the title Rollback #2785, as it made bom generation and smoke test for crashlytics fail. Rollback #2785, which made bom generation and smoke test for crashlytics fail. Jul 13, 2021
@yifanyang yifanyang changed the title Rollback #2785, which made bom generation and smoke test for crashlytics fail. Rollback #2785, which made bom generation and crashlytics smoke test fail. Jul 13, 2021
@yifanyang
Copy link
Contributor Author

@davidmotson @vkryachko

The problems are:

Despite of the crashlytics errors, to fix the bom task, I will need to build and push a new CI image. It's probably easier to rollback at this moment. Can you help me approve this PR?

The current approach of decoupling sdk and smoke test gradle requires below changes to be pushed (or reverted) at the same time:

  • smoke test src change in this repo
  • firehorn runner change in its docker image (already rolled back now)
  • build_bom script change in the CI image

And not sure if I'm still missing some use case. I'll try to think of a cleaner way to do this.

@yifanyang yifanyang marked this pull request as ready for review July 13, 2021 18:25
@yifanyang yifanyang merged commit 4f1cdc8 into master Jul 13, 2021
@yifanyang yifanyang deleted the yifany/trigger-smoke-tests branch July 13, 2021 18:41
@firebase firebase locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @vkryachko @googlebot