Skip to content

update grpc version #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 13, 2021
Merged

update grpc version #2788

merged 11 commits into from
Oct 13, 2021

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jul 2, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage did not change between base commit (e1f356a) and head commit (10e86cf1). However there are changes in individual files.

    Filename Base (e1f356a) Head (10e86cf1) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    DoubleNode.java 100.00% 88.24% -11.76%
    ViewProcessor.java 91.79% 92.10% +0.30%

  • firebase-firestore

    SDK overall coverage changed from 43.62% (e1f356a) to 43.89% (10e86cf1) by +0.27%.

    Filename Base (e1f356a) Head (10e86cf1) Diff
    DeleteMutation.java 90.00% 95.00% +5.00%
    FirestoreGrpc.java 8.73% 2.62% -6.11%

  • firebase-inappmessaging

    SDK overall coverage changed from 37.83% (e1f356a) to 37.62% (10e86cf1) by -0.21%.

    Filename Base (e1f356a) Head (10e86cf1) Diff
    InAppMessagingSdkServingGrpc.java 66.20% 51.22% -14.98%

  • firebase-messaging

    SDK overall coverage changed from 84.13% (e1f356a) to 84.09% (10e86cf1) by -0.04%.

    Filename Base (e1f356a) Head (10e86cf1) Diff
    ProxyNotificationInitializer.java 83.33% 81.25% -2.08%

  • firebase-storage

    SDK overall coverage changed from 85.85% (e1f356a) to 85.81% (10e86cf1) by -0.04%.

    Filename Base (e1f356a) Head (10e86cf1) Diff
    UploadTask.java 80.58% 80.22% -0.36%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (10e86cf1) is created by Prow via merging commits: e1f356a 7352027.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (e1f356a) Head (10e86cf1) Diff
    aar 1.21 MB 1.21 MB +24 B (+0.0%)
    apk (aggressive) 443 kB 443 kB +100 B (+0.0%)
    apk (release) 3.25 MB 3.32 MB +68.1 kB (+2.1%)

  • firebase-firestore-ktx

    Type Base (e1f356a) Head (10e86cf1) Diff
    aar 7.17 kB 7.17 kB +1 B (+0.0%)
    apk (aggressive) 458 kB 459 kB +24 B (+0.0%)
    apk (release) 3.73 MB 3.80 MB +65.9 kB (+1.8%)

  • firebase-inappmessaging

    Type Base (e1f356a) Head (10e86cf1) Diff
    aar 469 kB 469 kB +25 B (+0.0%)
    apk (aggressive) 642 kB 655 kB +13.7 kB (+2.1%)
    apk (release) 3.34 MB 3.39 MB +54.9 kB (+1.6%)

  • firebase-inappmessaging-display

    Type Base (e1f356a) Head (10e86cf1) Diff
    apk (aggressive) 1.48 MB 1.49 MB +12.2 kB (+0.8%)
    apk (release) 4.59 MB 4.66 MB +68.1 kB (+1.5%)

  • firebase-inappmessaging-display-ktx

    Type Base (e1f356a) Head (10e86cf1) Diff
    apk (aggressive) 1.49 MB 1.51 MB +12.1 kB (+0.8%)
    apk (release) 5.08 MB 5.14 MB +68.5 kB (+1.3%)

  • firebase-inappmessaging-ktx

    Type Base (e1f356a) Head (10e86cf1) Diff
    apk (aggressive) 657 kB 672 kB +14.1 kB (+2.1%)
    apk (release) 3.82 MB 3.87 MB +55.2 kB (+1.4%)

Test Logs

Notes

Head commit (10e86cf1) is created by Prow via merging commits: e1f356a 7352027.

@jeremyjiang-dev jeremyjiang-dev mentioned this pull request Jul 8, 2021
Merged
@davidmotson
Copy link
Collaborator Author

/retest

1 similar comment
@davidmotson
Copy link
Collaborator Author

/retest

vkryachko
vkryachko reviewed Oct 13, 2021
View reviewed changes
build.gradle Outdated
@@ -46,7 +46,7 @@ ext {
playServicesVersion = '16.0.1'
supportAnnotationsVersion = '28.0.0'
googleTruthVersion = '0.45'
grpcVersion = '1.28.0'
grpcVersion = '1.38.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to go all the way to 1.41.0?

vkryachko
vkryachko approved these changes Oct 13, 2021
View reviewed changes
firebase-firestore/firebase-firestore.gradle
@@ -57,7 +57,7 @@ android {
compileSdkVersion project.targetSdkVersion
defaultConfig {
targetSdkVersion project.targetSdkVersion
minSdkVersion project.minSdkVersion
minSdkVersion 19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmidt-sebastian fyi

@google-oss-bot
Copy link
Contributor

@davidmotson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 7352027 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidmotson davidmotson merged commit 7d40d4c into master Oct 13, 2021
@davidmotson davidmotson deleted the davidmotson.grpc_update branch October 13, 2021 21:02
@gsakakihara gsakakihara mentioned this pull request Oct 20, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidmotson @google-oss-bot @vkryachko @googlebot @jeremyjiang-dev