Skip to content

Fix flaky tests in FirebasePerformanceTest.java #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

jeremyjiang-dev
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev commented Jul 8, 2021

This PR will unblock #2788.
check-changed should be passing based on the test result from #2813, which is based on #2788.

Context:
The failure examples could be found here

@googlebot googlebot added the cla: yes Override cla label Jul 8, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (20cd7fa) and head commit (9bc998fd).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (9bc998fd) is created by Prow via merging commits: 20cd7fa a370e28.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (20cd7fa) and head commit (9bc998fd).

Test Logs

Notes

Head commit (9bc998fd) is created by Prow via merging commits: 20cd7fa a370e28.

@jeremyjiang-dev jeremyjiang-dev merged commit ddd755e into master Jul 14, 2021
@jeremyjiang-dev jeremyjiang-dev deleted the perfFlakyTests branch July 14, 2021 13:46
@firebase firebase locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants