Move fcm to github #2971

VinayGuthal · 2021-09-13T06:23:47Z

This pr update fcm in github.

The following tests have been ignored.

com.google.firebase.messaging.MessagingAnalyticsRoboTest > testShouldExportDeliveryMetricsToBigQuery_noneManifestNoneSetter

com.google.firebase.messaging.MessagingAnalyticsRoboTest > testTopicsApiPopulatesParamTopic_fromComposerUiWithFromNotATopic

com.google.firebase.messaging.MessagingAnalyticsRoboTest > getInstanceId_withIntentTo

com.google.firebase.messaging.MessagingAnalyticsRoboTest > testShouldExportDeliveryMetricsToBigQuery_falseManifestTrueSetter

com.google.firebase.messaging.DisplayNotificationRoboTest > testNonAdaptiveIconWithGradient_AndroidO FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testColor FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testNonAdaptiveIcon_AndroidO FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testColorFromMetadata FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testAdaptiveIcon_viaMetadata FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testAdaptiveIcon_viaDefaultIcon FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testAdaptiveIcon_beforeAndroidO FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testAdaptiveIcon_viaParameter FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.DisplayNotificationRoboTest > testNoColor FAILED
java.lang.OutOfMemoryError

com.google.firebase.messaging.FirebaseMessagingRoboTest > proxyNotificationEnabledIsTrueWhenGMSCoreIsSetAsNotificationDelegate FAILED
com.google.common.truth.AssertionErrorWithFacts at FirebaseMessagingRoboTest.java:445

com.google.firebase.messaging.FirebaseMessagingRoboTest > setEnableProxyNotificationWorksOnNewerDevices FAILED
com.google.common.truth.AssertionErrorWithFacts at FirebaseMessagingRoboTest.java:418

com.google.firebase.messaging.FirebaseMessagingRoboTest > setEnableProxyNotificationFailsOnOlderDevices FAILED
java.lang.OutOfMemoryError
Caused by: java.lang.OutOfMemoryError

com.google.firebase.messaging.FirebaseMessagingRoboTest > isProxyNotificationEnabledDefaultsToFalseForOlderDevices FAILED
java.lang.OutOfMemoryError
Caused by: java.lang.OutOfMemoryError

com.google.firebase.messaging.FirebaseMessagingRoboTest > isProxyNotificationEnabledDefaultsToTrueForNewerDevices FAILED
com.google.common.truth.AssertionErrorWithFacts at FirebaseMessagingRoboTest.java:385

com.google.firebase.messaging.FirebaseMessagingServiceRoboTest > testNotification_clickAnalytics FAILED
java.lang.RuntimeException at FirebaseMessagingServiceRoboTest.java:599

com.google.firebase.messaging.FirebaseMessagingServiceRoboTest > testNotification_clickAnalytics_recreateActivity FAILED
java.lang.RuntimeException at FirebaseMessagingServiceRoboTest.java:601

FolderOrigin-RevId: /google/src/cloud/vguthal/fcm_migration/.

googlebot · 2021-09-13T06:23:54Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-13T06:23:54Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-oss-bot · 2021-09-13T06:29:55Z

The public api surface has changed for the subproject firebase-messaging:
error: Added method com.google.firebase.messaging.FirebaseMessaging.deleteToken() [AddedMethod]
error: Method com.google.firebase.messaging.FirebaseMessaging.deliveryMetricsExportToBigQueryEnabled has changed deprecation state true --> false [ChangedDeprecated]
error: Added method com.google.firebase.messaging.FirebaseMessaging.getToken() [AddedMethod]
error: Removed method com.google.firebase.messaging.FirebaseMessaging.isDeliveryMetricsExportToBigQueryEnabled() [RemovedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.isNotificationDelegationEnabled() [AddedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.setNotificationDelegationEnabled(boolean) [AddedMethod]
error: Field com.google.firebase.messaging.FirebaseMessaging.INSTANCE_ID_SCOPE has changed deprecation state false --> true [ChangedDeprecated]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-09-13T06:33:08Z

Coverage Report

Affected SDKs

`firebase-messaging`

SDK overall coverage changed from ? (b9f0ab6) to 84.13% (5edfd8ff) by ?.

Click to show coverage changes in 40 files.

Filename	Base (`b9f0ab6`)	Head (5edfd8ff)	Diff
AutoProtoEncoderDoNotUseEncoder.java	?	98.17%	?
CommonNotificationBuilder.java	?	86.83%	?
Constants.java	?	92.86%	?
DisplayNotification.java	?	91.38%	?
EnhancedIntentService.java	?	76.60%	?
ExecutorFactory.java	?	0.00%	?
FcmBroadcastProcessor.java	?	83.33%	?
FcmExecutors.java	?	60.00%	?
FcmLifecycleCallbacks.java	?	15.00%	?
FirebaseInstanceIdReceiver.java	?	72.73%	?
FirebaseMessaging.java	?	74.22%	?
FirebaseMessagingRegistrar.java	?	100.00%	?
FirebaseMessagingService.java	?	94.03%	?
GmsRpc.java	?	83.15%	?
ImageDownload.java	?	87.18%	?
MessagingAnalytics.java	?	82.64%	?
MessagingClientEvent.java	?	93.58%	?
MessagingClientEventExtension.java	?	76.47%	?
Metadata.java	?	57.14%	?
NotificationParams.java	?	98.71%	?
PoolableExecutors.java	?	29.17%	?
ProtoEncoderDoNotUse.java	?	50.00%	?
ProxyNotificationInitializer.java	?	83.33%	?
ProxyNotificationPreferences.java	?	88.89%	?
RemoteMessage.java	?	95.48%	?
RemoteMessageCreator.java	?	88.89%	?
RequestDeduplicator.java	?	90.00%	?
SendException.java	?	100.00%	?
ServiceStarter.java	?	87.50%	?
SharedPreferencesQueue.java	?	98.65%	?
Store.java	?	74.19%	?
SyncTask.java	?	70.83%	?
ThreadPriority.java	?	100.00%	?
TopicOperation.java	?	90.00%	?
TopicsStore.java	?	100.00%	?
TopicsSubscriber.java	?	88.60%	?
TopicsSyncTask.java	?	49.33%	?
WakeLockHolder.java	?	95.00%	?
WithinAppServiceBinder.java	?	90.91%	?
WithinAppServiceConnection.java	?	83.75%	?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (5edfd8ff) is created by Prow via merging commits: b9f0ab6 fe65cd1.

google-oss-bot · 2021-09-13T06:35:53Z

Binary Size Report

Affected SDKs

firebase-messaging

Type Base (b9f0ab6) Head (5edfd8ff) Diff

aar 170 kB 221 kB +51.5 kB (+30.4%)

apk (aggressive) 507 kB 544 kB +36.9 kB (+7.3%)

apk (release) 2.46 MB 2.46 MB +4.61 kB (+0.2%)

Test Logs

Notes

Head commit (5edfd8ff) is created by Prow via merging commits: b9f0ab6 fe65cd1.

VinayGuthal · 2021-09-13T06:50:25Z

/test check-changed

google-oss-bot · 2021-09-13T07:17:22Z

The public api surface has changed for the subproject firebase-messaging:
error: Added method com.google.firebase.messaging.FirebaseMessaging.deleteToken() [AddedMethod]
error: Method com.google.firebase.messaging.FirebaseMessaging.deliveryMetricsExportToBigQueryEnabled has changed deprecation state true --> false [ChangedDeprecated]
error: Added method com.google.firebase.messaging.FirebaseMessaging.getToken() [AddedMethod]
error: Removed method com.google.firebase.messaging.FirebaseMessaging.isDeliveryMetricsExportToBigQueryEnabled() [RemovedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.isNotificationDelegationEnabled() [AddedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.setNotificationDelegationEnabled(boolean) [AddedMethod]
error: Field com.google.firebase.messaging.FirebaseMessaging.INSTANCE_ID_SCOPE has changed deprecation state false --> true [ChangedDeprecated]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-09-13T07:22:41Z

The public api surface has changed for the subproject firebase-messaging:
error: Added method com.google.firebase.messaging.FirebaseMessaging.deleteToken() [AddedMethod]
error: Method com.google.firebase.messaging.FirebaseMessaging.deliveryMetricsExportToBigQueryEnabled has changed deprecation state true --> false [ChangedDeprecated]
error: Added method com.google.firebase.messaging.FirebaseMessaging.getToken() [AddedMethod]
error: Removed method com.google.firebase.messaging.FirebaseMessaging.isDeliveryMetricsExportToBigQueryEnabled() [RemovedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.isNotificationDelegationEnabled() [AddedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.setNotificationDelegationEnabled(boolean) [AddedMethod]
error: Field com.google.firebase.messaging.FirebaseMessaging.INSTANCE_ID_SCOPE has changed deprecation state false --> true [ChangedDeprecated]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

VinayGuthal · 2021-09-13T07:22:43Z

/test copyright-check

google-oss-bot · 2021-09-13T07:34:13Z

The public api surface has changed for the subproject firebase-messaging:
error: Added method com.google.firebase.messaging.FirebaseMessaging.deleteToken() [AddedMethod]
error: Method com.google.firebase.messaging.FirebaseMessaging.deliveryMetricsExportToBigQueryEnabled has changed deprecation state true --> false [ChangedDeprecated]
error: Added method com.google.firebase.messaging.FirebaseMessaging.getToken() [AddedMethod]
error: Removed method com.google.firebase.messaging.FirebaseMessaging.isDeliveryMetricsExportToBigQueryEnabled() [RemovedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.isNotificationDelegationEnabled() [AddedMethod]
error: Added method com.google.firebase.messaging.FirebaseMessaging.setNotificationDelegationEnabled(boolean) [AddedMethod]
error: Field com.google.firebase.messaging.FirebaseMessaging.INSTANCE_ID_SCOPE has changed deprecation state false --> true [ChangedDeprecated]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

googlebot · 2021-09-13T07:36:06Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-13T07:36:06Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-14T09:22:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-14T09:22:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-15T13:14:25Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T13:14:25Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-15T15:17:09Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T15:17:12Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-15T15:18:18Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T15:18:19Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-15T15:42:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T15:42:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

firebase-messaging/firebase-messaging.gradle

googlebot · 2021-09-15T15:59:31Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T15:59:32Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Googler and others added 7 commits September 3, 2021 08:50

Project import generated by Copybara.

9638fd2

FolderOrigin-RevId: /google/src/cloud/vguthal/fcm_migration/.

update

db95618

update

0302410

update

58be313

update

0b57d6c

add resourcrs

1277fed

move fcm

8c8f6d2

google-cla bot added the cla: no label Sep 13, 2021

google-oss-bot added the size/XXL label Sep 13, 2021

VinayGuthal added 2 commits September 13, 2021 12:41

update

f9191d3

update

d4839c2

update

58fdcba

VinayGuthal added cla: yes Override cla and removed cla: no labels Sep 13, 2021

update tests

bd2efe1

googlebot removed the cla: yes Override cla label Sep 14, 2021

google-cla bot added cla: no and removed cla: yes Override cla labels Sep 15, 2021

VinayGuthal added cla: yes Override cla and removed cla: no labels Sep 15, 2021

update

4ee8969

googlebot added cla: no and removed cla: yes Override cla labels Sep 15, 2021

VinayGuthal added cla: yes Override cla and removed cla: no labels Sep 15, 2021

update

0ba6567

googlebot added cla: no and removed cla: yes Override cla labels Sep 15, 2021

vkryachko reviewed Sep 15, 2021

View reviewed changes

firebase-messaging/firebase-messaging.gradle Outdated Show resolved Hide resolved

update

fe65cd1

vkryachko approved these changes Sep 15, 2021

View reviewed changes

VinayGuthal added cla: yes Override cla and removed cla: no labels Sep 15, 2021

VinayGuthal merged commit 21a9f91 into master Sep 15, 2021

VinayGuthal deleted the update_stuff branch September 15, 2021 16:02

firebase locked and limited conversation to collaborators Oct 16, 2021

Move fcm to github #2971

Move fcm to github #2971

Uh oh!

Conversation

VinayGuthal commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Sep 13, 2021

Uh oh!

google-cla bot commented Sep 13, 2021

Uh oh!

google-oss-bot commented Sep 13, 2021

Uh oh!

google-oss-bot commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Affected SDKs

firebase-messaging

Test Logs

Notes

Uh oh!

google-oss-bot commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

firebase-messaging

Test Logs

Notes

Uh oh!

VinayGuthal commented Sep 13, 2021

Uh oh!

google-oss-bot commented Sep 13, 2021

Uh oh!

google-oss-bot commented Sep 13, 2021

Uh oh!

VinayGuthal commented Sep 13, 2021

Uh oh!

google-oss-bot commented Sep 13, 2021

Uh oh!

googlebot commented Sep 13, 2021

Uh oh!

google-cla bot commented Sep 13, 2021

Uh oh!

googlebot commented Sep 14, 2021

Uh oh!

google-cla bot commented Sep 14, 2021

Uh oh!

googlebot commented Sep 15, 2021

Uh oh!

google-cla bot commented Sep 15, 2021

Uh oh!

googlebot commented Sep 15, 2021

Uh oh!

google-cla bot commented Sep 15, 2021

Uh oh!

googlebot commented Sep 15, 2021

Uh oh!

google-cla bot commented Sep 15, 2021

Uh oh!

googlebot commented Sep 15, 2021

Uh oh!

google-cla bot commented Sep 15, 2021

Uh oh!

Uh oh!

googlebot commented Sep 15, 2021

Uh oh!

google-cla bot commented Sep 15, 2021

Uh oh!

Uh oh!

VinayGuthal commented Sep 13, 2021 •

edited

Loading

google-oss-bot commented Sep 13, 2021 •

edited

Loading

`firebase-messaging`

google-oss-bot commented Sep 13, 2021 •

edited

Loading

`firebase-messaging`