Skip to content

Adding in api.txt files to ktx and app distribution directories #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

Adding in api.txt files to ktx and app distribution directories #3110

merged 5 commits into from
Nov 8, 2021

Conversation

manny-jimenez
Copy link
Contributor

All sdks have an api.txt files that include methods that users will be interacting with both on java and in kotlin.

@google-cla google-cla bot added the cla: yes Override cla label Nov 8, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 8, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (c293a6e) and head commit (ae0b142b).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ae0b142b) is created by Prow via merging commits: c293a6e 64eb02e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 8, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • base

    Type Base (c293a6e) Head (ae0b142b) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.65 kB ? (?)

  • firebase-annotations

    Type Base (c293a6e) Head (ae0b142b) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.83 kB ? (?)

  • firebase-app-distribution

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 120 kB ? (?)
    apk (aggressive) ? 739 kB ? (?)
    apk (release) ? 1.55 MB ? (?)

  • firebase-app-distribution-ktx

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 20.0 kB ? (?)
    apk (aggressive) ? 759 kB ? (?)
    apk (release) ? 2.03 MB ? (?)

  • firebase-common

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 45.5 kB ? (?)
    apk (aggressive) ? 77.8 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-common-ktx

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 5.98 kB ? (?)
    apk (aggressive) ? 93.4 kB ? (?)
    apk (release) ? 1.11 MB ? (?)

  • firebase-components

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 41.4 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.5 kB ? (?)

  • firebase-installations

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 54.6 kB ? (?)
    apk (aggressive) ? 79.5 kB ? (?)
    apk (release) ? 658 kB ? (?)

  • firebase-installations-interop

    Type Base (c293a6e) Head (ae0b142b) Diff
    aar ? 8.06 kB ? (?)
    apk (aggressive) ? 55.4 kB ? (?)
    apk (release) ? 607 kB ? (?)

Test Logs

Notes

Head commit (ae0b142b) is created by Prow via merging commits: c293a6e 64eb02e.

pranavrajgopal
pranavrajgopal reviewed Nov 8, 2021
View reviewed changes
pranavrajgopal
pranavrajgopal approved these changes Nov 8, 2021
View reviewed changes
@manny-jimenez manny-jimenez merged commit 9e93fff into master Nov 8, 2021
@manny-jimenez manny-jimenez deleted the fad_api_txt branch November 8, 2021 16:21
ehsannas
ehsannas reviewed Dec 7, 2021
View reviewed changes
firebase-app-distribution/api.txt
method @NonNull public com.google.android.gms.tasks.Task<java.lang.Void> signInTester();
method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.app.distribution.AppDistributionRelease> checkForNewRelease();
method @NonNull public com.google.firebase.app.distribution.UpdateTask updateApp();
method public java.lang.Boolean istesterSignedIn()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ; at the end of the line here.

@ehsannas
Copy link
Contributor

ehsannas commented Dec 7, 2021

I see CI bots failing on my PR for Firestore because the bots run apiInformation for all firebase components (e.g. ./gradlew :firebase-app-distribution:apiInformation)
https://storage.googleapis.com/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3185/api-information/1467983777874579459/build-log.txt

@ehsannas
Copy link
Contributor

ehsannas commented Dec 7, 2021

AFAIK the api.txt files should be auto-generated by running ./gradlew :firebase-app-distribution:generateApiTxtFile

@ehsannas
Copy link
Contributor

ehsannas commented Dec 7, 2021

I have posted #3213 to fix this, but I'm not familiar with app distribution APIs. Please review.

@firebase firebase locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas left review comments

@pranavrajgopal pranavrajgopal pranavrajgopal approved these changes

@rachaprince rachaprince rachaprince approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manny-jimenez @google-oss-bot @ehsannas @pranavrajgopal @rachaprince