Skip to content

Fix app distribution api.txt files. #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix app distribution api.txt files. #3213

wants to merge 1 commit into from

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Dec 7, 2021

No description provided.

@ehsannas ehsannas mentioned this pull request Dec 7, 2021
Merged
@ehsannas
Copy link
Contributor Author

ehsannas commented Dec 7, 2021

tip-of-tree seems to be broken. (Running ./gradlew :firebase-app-distribution:apiInformation fails).

This change automatically generated by running ./gradlew :firebase-app-distribution:generateApiTxtFile

@ehsannas ehsannas mentioned this pull request Dec 7, 2021
Closed
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-app-distribution:
error: Added class com.google.firebase.app.distribution.AppDistributionReleaseInternal [AddedClass]
error: Added constructor com.google.firebase.app.distribution.FirebaseAppDistribution(com.google.firebase.FirebaseApp,com.google.firebase.installations.FirebaseInstallationsApi,com.google.firebase.app.distribution.SignInStorage,com.google.firebase.app.distribution.FirebaseAppDistributionLifecycleNotifier) [AddedMethod]
error: Removed constructor com.google.firebase.app.distribution.FirebaseAppDistribution(com.google.firebase.FirebaseApp,com.google.firebase.installations.FirebaseInstallationsApi,com.google.firebase.app.distribution.SignInStorage,com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier) [RemovedMethod]
error: Added class com.google.firebase.app.distribution.FirebaseAppDistributionLifecycleNotifier [AddedClass]
error: Added class com.google.firebase.app.distribution.ReleaseIdentificationUtils [AddedClass]
error: Removed class com.google.firebase.app.distribution.ReleaseIdentifierStorage [RemovedClass]
error: Removed class com.google.firebase.app.distribution.UpdateAppClient [RemovedClass]
error: Removed package com.google.firebase.app.distribution.internal [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@ehsannas: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 8ad3df0 link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from ? (f104b6a) to 66.31% (eec35322) by ?.

    Click to show coverage changes in 31 files.
    Filename Base (f104b6a) Head (eec35322) Diff
    AppDistributionRelease.java ? 100.00% ?
    AppDistributionReleaseInternal.java ? 100.00% ?
    AutoValue_AppDistributionRelease.java ? 65.45% ?
    AutoValue_AppDistributionReleaseInternal.java ? 66.67% ?
    AutoValue_UpdateProgress.java ? 65.96% ?
    BinaryType.java ? 100.00% ?
    CheckForNewReleaseClient.java ? 81.82% ?
    Constants.java ? 0.00% ?
    FirebaseAppDistribution.java ? 80.86% ?
    FirebaseAppDistributionException.java ? 86.67% ?
    FirebaseAppDistributionFileProvider.java ? 0.00% ?
    FirebaseAppDistributionLifecycleNotifier.java ? 0.00% ?
    FirebaseAppDistributionNotificationsManager.java ? 92.16% ?
    FirebaseAppDistributionRegistrar.java ? 45.00% ?
    FirebaseAppDistributionTesterApiClient.java ? 78.75% ?
    InstallActivity.java ? 4.35% ?
    InstallApkClient.java ? 89.80% ?
    LogWrapper.java ? 73.33% ?
    OnProgressListener.java ? 0.00% ?
    ReleaseIdentificationUtils.java ? 9.43% ?
    ReleaseUtils.java ? 76.92% ?
    SignInResultActivity.java ? 0.00% ?
    SignInStorage.java ? 0.00% ?
    TaskUtils.java ? 95.00% ?
    TesterSignInClient.java ? 84.62% ?
    UpdateAabClient.java ? 84.93% ?
    UpdateApkClient.java ? 53.85% ?
    UpdateProgress.java ? 100.00% ?
    UpdateStatus.java ? 100.00% ?
    UpdateTask.java ? 100.00% ?
    UpdateTaskImpl.java ? 84.38% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (eec35322) is created by Prow via merging commits: f104b6a 8ad3df0.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (f104b6a) and head commit (eec35322).

Test Logs

Notes

Head commit (eec35322) is created by Prow via merging commits: f104b6a 8ad3df0.

rachaprince
rachaprince approved these changes Dec 9, 2021
View reviewed changes
Copy link

@rachaprince rachaprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this review. Thank you for putting this together.

It looks like there are still a few lint tests that are failing

@rachaprince rachaprince mentioned this pull request Dec 10, 2021
Closed
@rachaprince
Copy link

I created #3232 which also includes a re-generation of the kotlin api files to get the api-information check to pass

@ehsannas
Copy link
Contributor Author

Thanks @rachaprince . I'll close this PR in favor of #3232

@ehsannas ehsannas closed this Dec 10, 2021
@firebase firebase locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachaprince rachaprince rachaprince approved these changes

@manny-jimenez manny-jimenez Awaiting requested review from manny-jimenez

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @rachaprince