-
Notifications
You must be signed in to change notification settings - Fork 626
Fix API text files for App Distribution #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage ReportAffected SDKsNo changes between base commit (8bc2ab4) and head commit (28e4b040). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (28e4b040) is created by Prow via merging commits: 8bc2ab4 6679cca. |
Binary Size ReportAffected SDKsNo changes between base commit (8bc2ab4) and head commit (28e4b040). Test Logs
NotesHead commit (28e4b040) is created by Prow via merging commits: 8bc2ab4 6679cca. |
A couple questions:
|
Good callout, let's wait for Manny's PR to land. The second question is also a good one. It seems like the |
Thanks @rachaprince for fixing this. I didn't have time to work on #3213 any further. I'll close that. |
Looking at the public api files generated by the script, I think there are still some places where we will want to reduce the visibility of methods and classes |
Closing this in favor of #3235, which limits the number of public classes and methods |
Based off #3213 . Fixes both the java and kotlin api text files by running
/gradlew :firebase-app-distribution:generateApiTxtFile
and/gradlew :firebase-app-distribution:ktx:generateApiTxtFile