String format with decimal issue in Android 8.1.0 #3176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKsNo changes between base commit (42542ba) and head commit (1ac46bd9). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (1ac46bd9) is created by Prow via merging commits: 42542ba 660439b. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (1ac46bd9) is created by Prow via merging commits: 42542ba 660439b. |
|
/retest |
|
/test check-changed |
|
/test device-check-changed |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
visumickey
approved these changes
Nov 29, 2021
jeremyjiang-dev
approved these changes
Nov 29, 2021
leotianlizhan
approved these changes
Nov 29, 2021
|
/test cla/google |
|
/retest |
|
/test cla/google |
|
/retest |
|
/test cla/google |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for issue #3084. NullPointerException is encountered specifically on Android version 8.1.0, this is due to String.format inserted with Double values.
The proposed fix is to use DecimalFormat to format the values before being inserted in String.format