String format with decimal issue in Android 8.1.0 #3084

[visumickey]

Speculative fix for issue #3084. NullPointerException is encountered specifically on Android version 8.1.0, this is due to String.format inserted with Double values.

The proposed fix is to use DecimalFormat to format the values before being inserted in String.format

[google-oss-bot]

Coverage Report

Affected SDKs

No changes between base commit (e2f4a3e) and head commit (40ca05f5).

Test Logs

• Base (e2f4a3ef): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1470464191688085504
• Head (40ca05f5): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3241/check-coverage-changed/1470659300266348546

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (40ca05f5) is created by Prow via merging commits: e2f4a3e caf07e0.

[google-oss-bot]

@visumickey: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
check-changed	caf07e0	link	/test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-perf

  Type	Base (e2f4a3e)	Head (40ca05f5)	Diff
  aar	301 kB	301 kB	+25 B (+0.0%)
  apk (aggressive)	980 kB	981 kB	+52 B (+0.0%)
  apk (release)	2.45 MB	2.45 MB	+16 B (+0.0%)

Test Logs

• Base (e2f4a3ef): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1470464192015241217
• Head (40ca05f5): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3241/binary-size/1470659300266348547

Notes

Head commit (40ca05f5) is created by Prow via merging commits: e2f4a3e caf07e0.

[argzdev]

Hi team, terribly sorry for the delay! We had some problems with the CLA, but it's been resolved now. Here is the PR: #3176

Thank you for your understanding!

[argzdev]

Hi team, just wanted to inform you that this PR has been merged on

#3176

This is now safe to close.
Thank you!