Skip to content

Removing internal package #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2021
Merged

Removing internal package #3190

merged 3 commits into from
Nov 30, 2021

Conversation

manny-jimenez
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Nov 30, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (88cea33) and head commit (2305daf2).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2305daf2) is created by Prow via merging commits: 88cea33 0b271be.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (88cea33) Head (2305daf2) Diff
    aar 120 kB 119 kB -172 B (-0.1%)
    apk (release) 1.55 MB 1.55 MB -44 B (-0.0%)

Test Logs

Notes

Head commit (2305daf2) is created by Prow via merging commits: 88cea33 0b271be.

@manny-jimenez manny-jimenez merged commit 97bac87 into master Nov 30, 2021
@manny-jimenez manny-jimenez deleted the fad_remove_internal branch November 30, 2021 20:46
schmidt-sebastian pushed a commit that referenced this pull request Dec 1, 2021
@manny-jimenez @schmidt-sebastian
Removing internal package (#3190)
842b583 
* Removing internal package

* Lint fixes

* Cleaning up builder

Co-authored-by: Manny Jimenez <[email protected]>
@firebase firebase locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajgopal pranavrajgopal pranavrajgopal approved these changes

@rachaprince rachaprince rachaprince approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manny-jimenez @google-oss-bot @pranavrajgopal @rachaprince