Skip to content

Removing internal package #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Removing internal package #3190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d22b7ae
Removing internal package
Nov 30, 2021
cf5dbfa
Lint fixes
Nov 30, 2021
0b271be
Cleaning up builder
Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ernal/AppDistributionReleaseInternal.java → ...ution/AppDistributionReleaseInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.firebase.app.distribution.internal;
package com.google.firebase.app.distribution;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.google.auto.value.AutoValue;
import com.google.firebase.app.distribution.BinaryType;

/**
* This class represents the AppDistributionRelease object returned by the App Distribution backend
Expand Down
4 changes: 1 addition & 3 deletions ...ribution/src/main/java/com/google/firebase/app/distribution/CheckForNewReleaseClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

package com.google.firebase.app.distribution;

import static com.google.firebase.app.distribution.internal.ReleaseIdentificationUtils.calculateApkHash;
import static com.google.firebase.app.distribution.ReleaseIdentificationUtils.calculateApkHash;

import android.content.Context;
import android.content.pm.PackageInfo;
Expand All @@ -25,8 +25,6 @@
import com.google.android.gms.tasks.Task;
import com.google.android.gms.tasks.Tasks;
import com.google.firebase.FirebaseApp;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.ReleaseIdentificationUtils;
import com.google.firebase.installations.FirebaseInstallationsApi;
import com.google.firebase.installations.InstallationTokenResult;
import java.io.File;
Expand Down
2 changes: 0 additions & 2 deletions ...tribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
import com.google.firebase.FirebaseApp;
import com.google.firebase.app.distribution.Constants.ErrorMessages;
import com.google.firebase.app.distribution.FirebaseAppDistributionException.Status;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import com.google.firebase.installations.FirebaseInstallationsApi;

public class FirebaseAppDistribution {
Expand Down
2 changes: 1 addition & 1 deletion ...baseAppDistributionLifecycleNotifier.java → ...baseAppDistributionLifecycleNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.firebase.app.distribution.internal;
package com.google.firebase.app.distribution;

import android.app.Activity;
import android.app.Application;
Expand Down
1 change: 0 additions & 1 deletion .../src/main/java/com/google/firebase/app/distribution/FirebaseAppDistributionRegistrar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import androidx.annotation.Keep;
import androidx.annotation.NonNull;
import com.google.firebase.FirebaseApp;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import com.google.firebase.components.Component;
import com.google.firebase.components.ComponentContainer;
import com.google.firebase.components.ComponentRegistrar;
Expand Down
1 change: 0 additions & 1 deletion ...ain/java/com/google/firebase/app/distribution/FirebaseAppDistributionTesterApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import androidx.annotation.NonNull;
import com.google.android.gms.common.util.AndroidUtilsLight;
import com.google.android.gms.common.util.Hex;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import java.io.BufferedInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
Expand Down
1 change: 0 additions & 1 deletion ...app-distribution/src/main/java/com/google/firebase/app/distribution/InstallApkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import androidx.annotation.Nullable;
import com.google.android.gms.tasks.Task;
import com.google.android.gms.tasks.TaskCompletionSource;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;

class InstallApkClient {
private static final String TAG = "ApkInstallClient:";
Expand Down
3 changes: 1 addition & 2 deletions .../internal/ReleaseIdentificationUtils.java → ...tribution/ReleaseIdentificationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.firebase.app.distribution.internal;
package com.google.firebase.app.distribution;

import android.content.Context;
import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.google.firebase.app.distribution.LogWrapper;
import java.io.File;
import java.io.IOException;
import java.nio.ByteBuffer;
Expand Down
1 change: 0 additions & 1 deletion ...ribution/src/main/java/com/google/firebase/app/distribution/ReleaseIdentifierStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import android.content.Context;
import android.content.SharedPreferences;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;

public class ReleaseIdentifierStorage {

Expand Down
2 changes: 0 additions & 2 deletions ...ase-app-distribution/src/main/java/com/google/firebase/app/distribution/ReleaseUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

package com.google.firebase.app.distribution;

import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;

class ReleaseUtils {
static AppDistributionRelease convertToAppDistributionRelease(
AppDistributionReleaseInternal internalRelease) {
Expand Down
1 change: 0 additions & 1 deletion ...p-distribution/src/main/java/com/google/firebase/app/distribution/TesterSignInClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import com.google.android.gms.tasks.Tasks;
import com.google.firebase.FirebaseApp;
import com.google.firebase.app.distribution.Constants.ErrorMessages;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import com.google.firebase.installations.FirebaseInstallationsApi;
import java.util.List;

Expand Down
2 changes: 0 additions & 2 deletions ...-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateAabClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
import androidx.annotation.GuardedBy;
import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import java.io.IOException;
import java.net.URL;
import java.util.concurrent.Executor;
Expand Down
3 changes: 1 addition & 2 deletions ...-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateApkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
package com.google.firebase.app.distribution;

import static com.google.firebase.app.distribution.FirebaseAppDistributionException.Status.NETWORK_FAILURE;
import static com.google.firebase.app.distribution.ReleaseIdentificationUtils.calculateApkHash;
import static com.google.firebase.app.distribution.TaskUtils.safeSetTaskException;
import static com.google.firebase.app.distribution.TaskUtils.safeSetTaskResult;
import static com.google.firebase.app.distribution.internal.ReleaseIdentificationUtils.calculateApkHash;

import android.content.Context;
import androidx.annotation.GuardedBy;
Expand All @@ -26,7 +26,6 @@
import com.google.android.gms.tasks.Task;
import com.google.android.gms.tasks.TaskCompletionSource;
import com.google.firebase.FirebaseApp;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import java.io.BufferedOutputStream;
import java.io.File;
import java.io.IOException;
Expand Down
2 changes: 0 additions & 2 deletions ...tion/src/test/java/com/google/firebase/app/distribution/CheckForNewReleaseClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
import com.google.android.gms.tasks.Tasks;
import com.google.firebase.FirebaseApp;
import com.google.firebase.FirebaseOptions;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.ReleaseIdentificationUtils;
import com.google.firebase.installations.FirebaseInstallationsApi;
import com.google.firebase.installations.InstallationTokenResult;
import java.util.concurrent.Executor;
Expand Down
2 changes: 0 additions & 2 deletions ...ution/src/test/java/com/google/firebase/app/distribution/FirebaseAppDistributionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@
import com.google.firebase.FirebaseOptions;
import com.google.firebase.app.distribution.Constants.ErrorMessages;
import com.google.firebase.app.distribution.FirebaseAppDistributionException.Status;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import com.google.firebase.installations.InstallationTokenResult;
import java.util.ArrayList;
import java.util.List;
Expand Down
1 change: 0 additions & 1 deletion ...java/com/google/firebase/app/distribution/FirebaseAppDistributionTesterApiClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import android.content.Context;
import androidx.test.core.app.ApplicationProvider;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.InputStream;
Expand Down
1 change: 0 additions & 1 deletion ...istribution/src/test/java/com/google/firebase/app/distribution/InstallApkClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import android.content.Intent;
import com.google.android.gms.tasks.Task;
import com.google.firebase.app.distribution.FirebaseAppDistributionTest.TestActivity;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down
1 change: 0 additions & 1 deletion ...stribution/src/test/java/com/google/firebase/app/distribution/TesterSignInClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
import com.google.firebase.FirebaseOptions;
import com.google.firebase.app.distribution.Constants.ErrorMessages;
import com.google.firebase.app.distribution.FirebaseAppDistributionTest.TestActivity;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import com.google.firebase.installations.FirebaseInstallationsApi;
import com.google.firebase.installations.InstallationTokenResult;
import org.junit.Before;
Expand Down
2 changes: 0 additions & 2 deletions ...-distribution/src/test/java/com/google/firebase/app/distribution/UpdateAabClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
import androidx.test.core.app.ApplicationProvider;
import com.google.firebase.FirebaseApp;
import com.google.firebase.FirebaseOptions;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import com.google.firebase.app.distribution.internal.FirebaseAppDistributionLifecycleNotifier;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.util.ArrayList;
Expand Down
1 change: 0 additions & 1 deletion ...-distribution/src/test/java/com/google/firebase/app/distribution/UpdateApkClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import com.google.android.gms.tasks.Tasks;
import com.google.firebase.FirebaseApp;
import com.google.firebase.FirebaseOptions;
import com.google.firebase.app.distribution.internal.AppDistributionReleaseInternal;
import java.io.File;
import java.util.ArrayList;
import java.util.List;
Expand Down