Skip to content

Create firestore/Filter.java #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2021
Merged

Create firestore/Filter.java #3237

merged 4 commits into from
Dec 16, 2021

Conversation

ehsannas
Copy link
Contributor

Posting incremental changes towards supporting composite filters and disjunctions.

For the time being, firestore/Filter.java is restricted to Scope.LIBRARY, and is hidden for api.txt purposes.

@ehsannas ehsannas force-pushed the ehsann/or-queries-pr-1 branch from e471819 to 55641a9 Compare December 13, 2021 17:02
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 13, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 45.31% (7faa75f) to 45.24% (9b479175) by -0.06%.

    Filename Base (7faa75f) Head (9b479175) Diff
    BundleSerializer.java 89.43% 89.47% +0.04%
    FieldFilter.java 88.46% 91.04% +2.58%
    Filter.java 100.00% 0.00% -100.00%
    PatchMutation.java 100.00% 98.39% -1.61%
    Query.java 4.06% 4.04% -0.01%
    SQLiteIndexManager.java 99.06% 99.07% +0.00%
    SetMutation.java 97.14% 94.29% -2.86%
    Target.java 96.12% 96.08% -0.04%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (9b479175) is created by Prow via merging commits: 7faa75f b9b2978.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 13, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (7faa75f) Head (9b479175) Diff
    aar 1.23 MB 1.23 MB +1.27 kB (+0.1%)
    apk (release) 3.33 MB 3.33 MB +860 B (+0.0%)

Test Logs

Notes

Head commit (9b479175) is created by Prow via merging commits: 7faa75f b9b2978.

@ehsannas ehsannas changed the title Create firestore/Filter.java and remove firestore/core/Filter.java. Create firestore/Filter.java Dec 15, 2021
schmidt-sebastian
schmidt-sebastian reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

schmidt-sebastian
schmidt-sebastian approved these changes Dec 15, 2021
View reviewed changes
@ehsannas
Copy link
Contributor Author

/test smoke-tests

@ehsannas ehsannas merged commit cae3743 into master Dec 16, 2021
@ehsannas ehsannas deleted the ehsann/or-queries-pr-1 branch December 16, 2021 15:15
@firebase firebase locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian