Add keep on ComponentRegistrar to prevent renaming of key lookup

[mkj-gram]

The name com.google.firebase.components.ComponentRegistrar is used as a key for looking up in the manifest by ComponentDiscovery. If a developer uses -adaptclassstrings the string will be renamed and fail to lookup the correct name in the manifest. One such bug was reported at https://issuetracker.google.com/issues/209817768.

The developer should never use -adaptclassstrings without specifying a filter but since the code uses a type name for component discovery it is best practice to keep the name to ensure it is not renamed.

[google-oss-bot]

Hi @mkj-gram. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rlazo]

/ok-to-test

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-components

  Type	Base (66797a8)	Merge (b8ee6fb)	Diff
  aar	41.4 kB	41.4 kB	+19 B (+0.0%)

Test Logs

• Base (66797a8): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1487921991724830722
• Merge (b8ee6fb): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3287/binary-size/1488111729194831872

Notes

• Commit (b8ee6fb) is created by Prow via merging PR base commit (66797a8) and head commit (b09426c).

1. https://storage.googleapis.com/firebase-sdk-metric-reports/Qo2GKNzGlt.html

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (53ff022) and merge commit (d41b839).

Test Logs

• Base (53ff022): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1489305487227752448
• Merge (d41b839): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3287/check-coverage-changed/1489354495962910725

Notes

• Commit (d41b839) is created by Prow via merging PR base commit (53ff022) and head commit (deac088).
• Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

1. https://storage.googleapis.com/firebase-sdk-metric-reports/4bbDJVjImH.html

[rlazo]

@mkj-gram thanks for your contribution! Could you try syncing your branch to head and re-running the tests (commenting /retest)? Not sure what's causing the failures in check-changed.

[rlazo]

Also, please wait until #3384 is in to rebase your branch to make sure the fix is included. Thanks!

[mkj-gram]

/retest

[rlazo]

/test device-check-changed

[google-oss-bot]

@mkj-gram: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
device-check-changed	deac088	link	/test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rlazo]

Test failing is not related to the changes. Approved. Thanks!