Skip to content

fix ci failures #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2022
Merged

fix ci failures #3384

merged 3 commits into from
Jan 31, 2022

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented Jan 31, 2022 •
edited
Loading

Adding NO_WRAP and NO_PADDING to the encoding so that new line character doesn't show up and it doesn't cause e2e tests to fail or smoke tests to fail.

vkryachko
vkryachko reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I does not seem like the commit message adequately describes what is being changed. Can you provide a more detailed explanation? see go/cl-descriptions

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-common

    TypeBase (a26c34c)Merge (9a43f99)Diff
    aar47.5 kB47.5 kB+15 B (+0.0%)
    apk (release)637 kB637 kB+40 B (+0.0%)

Test Logs

Notes

  • Commit (9a43f99) is created by Prow via merging PR base commit (a26c34c) and head commit (6b8bc2b).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xcu6OpUXhp.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (a26c34c) and merge commit (9a43f99).

Test Logs

Notes

  • Commit (9a43f99) is created by Prow via merging PR base commit (a26c34c) and head commit (6b8bc2b).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/y5tjkoamk0.html

@VinayGuthal
Copy link
Contributor Author

/test check-changed

@rlazo
Copy link
Collaborator

rlazo commented Jan 31, 2022

Throughout the code in the repo the combination most commonly used was Base64.URL_SAFE | Base64.NO_WRAP | Base64.NO_PADDING, would it be necessary in this case?

@rlazo rlazo mentioned this pull request Jan 31, 2022
Merged
@VinayGuthal
Copy link
Contributor Author

/test check-changed

@VinayGuthal VinayGuthal merged commit e0d23be into master Jan 31, 2022
@VinayGuthal VinayGuthal deleted the fix_ci_failures branch January 31, 2022 19:57
@firebase firebase deleted a comment from google-oss-bot Jan 31, 2022
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko left review comments

@rlazo rlazo rlazo approved these changes

Assignees

@vkryachko vkryachko

@rlazo rlazo

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @rlazo @vkryachko