Skip to content

Smoke test maintenance #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

Smoke test maintenance #3379

merged 1 commit into from
Jan 31, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Jan 28, 2022 •
edited
Loading

  • Upgrade dependency versions
  • Replace jcenter with maven central repository
  • Revive temporarily disabled Messaging test cases

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (e0d23be) to 50.19% (547ae22) by +0.04%.

    FilenameBase (e0d23be)Merge (547ae22)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 45.35% (e0d23be) to 45.34% (547ae22) by -0.00%.

    FilenameBase (e0d23be)Merge (547ae22)Diff
    DeleteMutation.java95.00%90.00%-5.00%

  • firebase-messaging

    Overall coverage changed from 85.40% (e0d23be) to 85.32% (547ae22) by -0.08%.

    FilenameBase (e0d23be)Merge (547ae22)Diff
    FirebaseMessaging.java74.67%73.78%-0.89%
    MessagingAnalytics.java81.38%83.00%+1.62%
    TopicsSubscriber.java89.47%88.60%-0.88%
    TopicsSyncTask.java53.33%49.33%-4.00%

Test Logs

Notes

  • Commit (547ae22) is created by Prow via merging PR base commit (e0d23be) and head commit (30b0be5).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AxkRTJxwLA.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (e0d23be) and merge commit (547ae22).

Test Logs

Notes

  • Commit (547ae22) is created by Prow via merging PR base commit (e0d23be) and head commit (30b0be5).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YEJOglmwni.html

@yifanyang
Copy link
Contributor Author

/retest

@yifanyang
Copy link
Contributor Author

/test smoke-tests

@yifanyang yifanyang force-pushed the yifany/smoke-test branch 2 times, most recently from 1deab86 to d5493b5 Compare January 31, 2022 22:00
@yifanyang
Smoke test maintenance
30b0be5 
- Upgrade dependency versions
- Replace jcenter with maven central repository
- Revive temporarily disabled Messaging test cases
@yifanyang yifanyang requested review from vkryachko and rlazo January 31, 2022 22:51
@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 30b0be5 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang merged commit eeef364 into master Jan 31, 2022
@yifanyang yifanyang deleted the yifany/smoke-test branch January 31, 2022 23:09
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @rlazo