Implement on-demand fatals internally #3402

mrober · 2022-02-04T16:04:52Z

No description provided.

google-oss-bot · 2022-02-04T16:10:59Z

Coverage Report ¹

Affected Products

`firebase-crashlytics`

Overall coverage changed from 9.74% (2bf81a5) to 9.55% (449992c) by -0.19%.

Filename	Base (`2bf81a5`)	Merge (449992c)	Diff
CrashlyticsController.java	18.65%	18.40%	-0.26%
CrashlyticsCore.java	0.67%	0.63%	-0.05%
DataTransportCrashlyticsReportSender.java	38.89%	48.28%	+9.39%
OnDemandCounter.java	?	0.00%	?
ReportQueue.java	?	0.00%	?
SessionReportingCoordinator.java	45.39%	44.76%	-0.63%

Test Logs

Notes

Commit (449992c) is created by Prow via merging PR base commit (2bf81a5) and head commit (908fad4).
Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

https://storage.googleapis.com/firebase-sdk-metric-reports/jt1e7K2sQn.html

google-oss-bot · 2022-02-04T16:12:46Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2022-02-04T16:17:04Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (2bf81a5) Merge (449992c) Diff
aar 339 kB 346 kB +6.98 kB (+2.1%)
apk (aggressive) 215 kB 216 kB +1.51 kB (+0.7%)
apk (release) 890 kB 893 kB +2.40 kB (+0.3%)

Test Logs

Notes

Commit (449992c) is created by Prow via merging PR base commit (2bf81a5) and head commit (908fad4).

https://storage.googleapis.com/firebase-sdk-metric-reports/a3rMUMndU1.html

google-oss-bot · 2022-02-04T18:08:51Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

The blocking param is temp, I need to do some refactoring to make it never block for on-demand

google-oss-bot · 2022-02-11T18:19:06Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

mrichards

Approved. (Thorough code review was done in-person on 2/10.)

google-oss-bot · 2022-02-15T17:07:57Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2022-02-16T21:30:19Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2022-02-17T18:45:27Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2022-02-24T19:02:16Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

…ng copyright text

google-oss-bot · 2022-02-25T16:53:06Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.recordFatalException(Throwable) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

…est changes from main branch. This should be in a good state to merge after this. We need to followup with a change to create a FirebaseCrashlyticsInternal interface with the new internal api.

mrichards

A couple things to double check, up to you if changes are needed. Overall LGTM!

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/OnDemandCounter.java

...ase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/ReportQueue.java

…ill call from core directly.

google-oss-bot · 2022-03-15T16:01:01Z

@mrober: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	`908fad4`	link	`/test smoke-tests`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Prototype of on-demand fatals.

3c12f0b

google-oss-bot added the size/S label Feb 4, 2022

WIP - Add on demand count to internal keys

7f68a5f

google-oss-bot added size/M and removed size/S labels Feb 4, 2022

WIP - add rate limiting report queue before data transport.

ece82f0

The blocking param is temp, I need to do some refactoring to make it never block for on-demand

google-oss-bot added size/L and removed size/M labels Feb 11, 2022

mrichards approved these changes Feb 11, 2022

View reviewed changes

WIP - Read queue params from settings.

ebb819a

WIP - Clean up Tasks a bit. Fixed tests. Added .m2 repo.

c1e4aa2

google-oss-bot added size/XL and removed size/L labels Feb 16, 2022

mrober added 2 commits February 17, 2022 12:59

Merge branch 'master' into on-demand

061e1c8

WIP - Sync with main, update pom files to work with firebase bom

b3496a7

WIP - Updated recorded and added dropped on-demand counts to own class

14473b8

WIP - Plumbed the on-demand counter through properly, and added missi…

ae77a3e

…ng copyright text

mrober added 2 commits March 8, 2022 14:18

Merge branch 'master' into on-demand

4fb804b

Remove artifact files, make new internal api private, and pull in lat…

3e3f1fc

…est changes from main branch. This should be in a good state to merge after this. We need to followup with a change to create a FirebaseCrashlyticsInternal interface with the new internal api.

mrober changed the title ~~Prototype of on-demand fatals.~~ implement on-demand fatals internally Mar 9, 2022

mrober changed the title ~~implement on-demand fatals internally~~ Implement on-demand fatals internally Mar 9, 2022

mrichards approved these changes Mar 15, 2022

View reviewed changes

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/OnDemandCounter.java Outdated Show resolved Hide resolved

...ase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/ReportQueue.java Outdated Show resolved Hide resolved

Resolve comments. Revert FirebaseCrashlytics api change, the plugin w…

908fad4

…ill call from core directly.

google-oss-bot added size/L and removed size/XL labels Mar 15, 2022

mrober merged commit e324046 into master Mar 15, 2022

mrober deleted the on-demand branch March 15, 2022 16:10

firebase locked and limited conversation to collaborators Apr 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement on-demand fatals internally #3402

Implement on-demand fatals internally #3402

Uh oh!

mrober commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 4, 2022 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 4, 2022 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 11, 2022

Uh oh!

mrichards left a comment

Uh oh!

google-oss-bot commented Feb 15, 2022

Uh oh!

google-oss-bot commented Feb 16, 2022

Uh oh!

google-oss-bot commented Feb 17, 2022

Uh oh!

google-oss-bot commented Feb 24, 2022

Uh oh!

google-oss-bot commented Feb 25, 2022

Uh oh!

mrichards left a comment

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Mar 15, 2022

Uh oh!

Uh oh!

Implement on-demand fatals internally #3402

Implement on-demand fatals internally #3402

Uh oh!

Conversation

mrober commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Notes

Uh oh!

google-oss-bot commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Notes

Uh oh!

google-oss-bot commented Feb 4, 2022

Uh oh!

google-oss-bot commented Feb 11, 2022

Uh oh!

mrichards left a comment

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Feb 15, 2022

Uh oh!

google-oss-bot commented Feb 16, 2022

Uh oh!

google-oss-bot commented Feb 17, 2022

Uh oh!

google-oss-bot commented Feb 24, 2022

Uh oh!

google-oss-bot commented Feb 25, 2022

Uh oh!

mrichards left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Mar 15, 2022

Uh oh!

Uh oh!

google-oss-bot commented Feb 4, 2022 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

google-oss-bot commented Feb 4, 2022 •

edited

Loading

Size Report ¹

`firebase-crashlytics`