Skip to content

Add Firebase App Distribution to smoke tests #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Add Firebase App Distribution to smoke tests #3555

merged 1 commit into from
Mar 18, 2022

Conversation

rachaprince
Copy link

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (ea5490c) to 50.19% (222d7a5) by +0.01%.

    FilenameBase (ea5490c)Merge (222d7a5)Diff
    BooleanNode.java100.00%92.31%-7.69%
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java100.00%88.24%-11.76%

  • firebase-firestore

    Overall coverage changed from 45.65% (ea5490c) to 45.66% (222d7a5) by +0.01%.

    FilenameBase (ea5490c)Merge (222d7a5)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%

  • firebase-messaging

    Overall coverage changed from 84.78% (ea5490c) to 84.82% (222d7a5) by +0.04%.

    FilenameBase (ea5490c)Merge (222d7a5)Diff
    FirebaseMessaging.java74.67%75.11%+0.44%

Test Logs

Notes

  • Commit (222d7a5) is created by Prow via merging PR base commit (ea5490c) and head commit (9a747dc).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jgBd2Y1c6E.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (ea5490c) and merge commit (222d7a5).

Test Logs

Notes

  • Commit (222d7a5) is created by Prow via merging PR base commit (ea5490c) and head commit (9a747dc).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XR5Gtvlog9.html

@rachaprince
Copy link
Author

/retest

1 similar comment
@rachaprince
Copy link
Author

/retest

@vkryachko vkryachko requested review from yifanyang and removed request for vkryachko March 18, 2022 13:56
@rachaprince rachaprince merged commit 1667f33 into master Mar 18, 2022
@rachaprince rachaprince deleted the add-fad-to-smoke-tests branch March 18, 2022 18:18
rachaprince pushed a commit that referenced this pull request Mar 21, 2022
Revert "Add Firebase App Distribution to smoke tests (#3555)"
8a24139 
This reverts commit 1667f33.
@rachaprince rachaprince mentioned this pull request Mar 21, 2022
Merged
rachaprince pushed a commit that referenced this pull request Mar 21, 2022
Revert "Add Firebase App Distribution to smoke tests (#3555)" (#3576)
6e232d8 
This reverts commit 1667f33.
yifanyang pushed a commit that referenced this pull request Mar 23, 2022
@yifanyang
Add Firebase App Distribution to smoke tests (#3555)
2e7714a
@yifanyang yifanyang mentioned this pull request Mar 23, 2022
Merged
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
@jeremyjiang-dev
Add Firebase App Distribution to smoke tests (#3555)
f295163
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
@jeremyjiang-dev
Revert "Add Firebase App Distribution to smoke tests (#3555)" (#3576)
85d2ab8 
This reverts commit 1667f33.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Add Firebase App Distribution to smoke tests (#3555)
3cefbc8
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Revert "Add Firebase App Distribution to smoke tests (#3555)" (#3576)
196ee50 
This reverts commit 1667f33.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Add Firebase App Distribution to smoke tests (#3555)
10efe28
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Revert "Add Firebase App Distribution to smoke tests (#3555)" (#3576)
bf3fd65 
This reverts commit 1667f33.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Add Firebase App Distribution to smoke tests (#3555)
f29304d
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@jeremyjiang-dev
Revert "Add Firebase App Distribution to smoke tests (#3555)" (#3576)
998f1d6 
This reverts commit 1667f33.
@firebase firebase locked and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanyang yifanyang yifanyang approved these changes

@lfkellogg lfkellogg lfkellogg approved these changes

@manny-jimenez manny-jimenez manny-jimenez approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rachaprince @google-oss-bot @yifanyang @lfkellogg @manny-jimenez