Skip to content

Revert "Add Firebase App Distribution to smoke tests" #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

rachaprince
Copy link

Reverts #3555

Because app-distro has not been included in the BoM, it is causing smoke test failures for some other products. This removes app-distribution from smoke test temporarily. We will add it back when the product is out of beta (and added to the BoM).

Copy link
Contributor

@yifanyang yifanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.68% (a9ffa8b) to 45.68% (9a343ef) by +0.00%.

    FilenameBase (a9ffa8b)Merge (9a343ef)Diff
    SetMutation.java94.29%97.14%+2.86%
  • firebase-storage

    Overall coverage changed from 85.85% (a9ffa8b) to 85.94% (9a343ef) by +0.09%.

    FilenameBase (a9ffa8b)Merge (9a343ef)Diff
    UploadTask.java80.58%81.29%+0.72%
  • firebase-messaging

    FilenameBase (a9ffa8b)Merge (9a343ef)Diff
    FirebaseMessaging.java74.67%75.11%+0.44%
    MessagingAnalytics.java83.00%81.38%-1.62%
    Metadata.java57.14%61.90%+4.76%

Test Logs

Notes

  • Commit (9a343ef) is created by Prow via merging PR base commit (a9ffa8b) and head commit (8a24139).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1I7a4evCVl.html

@google-oss-bot
Copy link
Contributor

@rachaprince rachaprince merged commit 6e232d8 into master Mar 21, 2022
@rachaprince rachaprince deleted the revert-3555-add-fad-to-smoke-tests branch March 21, 2022 23:12
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@firebase firebase locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants